From: Shuah Khan <skhan@linuxfoundation.org>
To: Meng Li <li.meng@amd.com>, Huang Rui <ray.huang@amd.com>,
linux-pm@vger.kernel.org
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Nathan Fontenot <nathan.fontenot@amd.com>,
Deepak Sharma <deepak.sharma@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Jinzhou Su <Jinzhou.Su@amd.com>, Perry Yuan <Perry.Yuan@amd.com>,
Xiaojian Du <Xiaojian.Du@amd.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Borislav Petkov <bp@alien8.de>,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH V3 2/3] selftests: cpufreq: Add wapper script for test AMD P-State
Date: Fri, 22 Apr 2022 11:48:43 -0600 [thread overview]
Message-ID: <e301e6f0-0940-1db9-31a9-b066363b1ea2@linuxfoundation.org> (raw)
In-Reply-To: <20220421074152.599419-3-li.meng@amd.com>
On 4/21/22 1:41 AM, Meng Li wrote:
> Adds a wrapper shell script for the amd_pstate_testmod module.
>
> Signed-off-by: Meng Li <li.meng@amd.com>
> ---
> tools/testing/selftests/cpufreq/amd_pstate_testmod.sh | 4 ++++
> tools/testing/selftests/cpufreq/config | 1 +
> tools/testing/selftests/cpufreq/main.sh | 1 +
> 3 files changed, 6 insertions(+)
> create mode 100755 tools/testing/selftests/cpufreq/amd_pstate_testmod.sh
>
> diff --git a/tools/testing/selftests/cpufreq/amd_pstate_testmod.sh b/tools/testing/selftests/cpufreq/amd_pstate_testmod.sh
> new file mode 100755
> index 000000000000..5398ad568885
> --- /dev/null
> +++ b/tools/testing/selftests/cpufreq/amd_pstate_testmod.sh
> @@ -0,0 +1,4 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +# Tests the AMD P-State unit test infrastructure using amd_pstate_testmod kernel module.
> +$(dirname $0)/../kselftest/module.sh "amd_pstate_testmod" amd_pstate_testmod
The script could load the module and unload once the test is complete.
> diff --git a/tools/testing/selftests/cpufreq/config b/tools/testing/selftests/cpufreq/config
> index 75e900793e8a..374a8adbb34c 100644
> --- a/tools/testing/selftests/cpufreq/config
> +++ b/tools/testing/selftests/cpufreq/config
> @@ -13,3 +13,4 @@ CONFIG_DEBUG_LOCK_ALLOC=y
> CONFIG_PROVE_LOCKING=y
> CONFIG_LOCKDEP=y
> CONFIG_DEBUG_ATOMIC_SLEEP=y
> +CONFIG_AMD_PSTATE_TESTMOD=m
> diff --git a/tools/testing/selftests/cpufreq/main.sh b/tools/testing/selftests/cpufreq/main.sh
> index 60ce18ed0666..d3602fa11392 100755
> --- a/tools/testing/selftests/cpufreq/main.sh
> +++ b/tools/testing/selftests/cpufreq/main.sh
> @@ -6,6 +6,7 @@ source cpufreq.sh
> source governor.sh
> source module.sh
> source special-tests.sh
> +source amd_pstate_testmod.sh
>
Does the script check if the test module is loaded and bail out?
I don't see the check for CONFIG_AMD_PSTATE_TESTMOD enable and
module load.
> FUNC=basic # do basic tests by default
> OUTFILE=cpufreq_selftest
>
thanks,
-- Shuah
next prev parent reply other threads:[~2022-04-22 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 7:41 [PATCH V3 0/3] Add unit test module for AMD P-State driver Meng Li
2022-04-21 7:41 ` [PATCH V3 1/3] cpufreq: amd-pstate: Expose struct amd_cpudata Meng Li
2022-04-21 7:41 ` [PATCH V3 2/3] selftests: cpufreq: Add wapper script for test AMD P-State Meng Li
2022-04-22 17:48 ` Shuah Khan [this message]
2022-04-21 7:41 ` [PATCH V3 3/3] selftests: cpufreq: Add amd_pstate_testmod kernel module for testing Meng Li
2022-04-22 17:45 ` [PATCH V3 0/3] Add unit test module for AMD P-State driver Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e301e6f0-0940-1db9-31a9-b066363b1ea2@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=Jinzhou.Su@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=alexander.deucher@amd.com \
--cc=bp@alien8.de \
--cc=deepak.sharma@amd.com \
--cc=li.meng@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nathan.fontenot@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®