From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 166D013D297 for ; Tue, 21 Jan 2025 07:49:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737445753; cv=none; b=twA1E39qSQzcsV1tQT14HVstmnfvXxLdjz5wkF7OlXWHL0I/C4FxHPJ2jBwh7+k9aNsw6agpbTGs0Z1Cd3OXos6AobJHYIhddn9oSKJ2TLsXkcLJDMmnUqcGKKVgWSBjxLQdJ6DIbLub/OHi8Le8F2h29LD2sD7KPvaesahsYgw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737445753; c=relaxed/simple; bh=sOhvQb65goco3ZLcNuYPefopbrfDu0EAKv5UT40Kva8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gAxegOVV+27vIEzRxNyAPT6X3nHM8ba0if2FqALi/kj8L2OoTI8ejCpAKkFZ9hTKDsg3Dn7m4v6THoaQ5wABwd+D76ltBBrBMTGVzKTirb2ill1Yn6nNzlcYjepvVBOdei7iWYad3TUFX5TgmrV8xbD7T8tXjkPxDkWStshQKbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Nmp2a7rT; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Nmp2a7rT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737445749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pEWTOBE0YfA5NLzP4KdNTpkr07FskrCb/W5+adJSTLI=; b=Nmp2a7rTGfXWrbiHgnvyPkcBbKn5gmaYOAMHF9AivPuNgrVYVCZSQt5SO7X6RJn5R7t8th aQXhpY8ta2+p6GbMb1kESP8J6fYtRcj2pHjipEfJqIkLfQnoYEZVoh9vT9kYJfc2CjHrFM bM0uy9jpNMSj2Yu0g7VQAXc7PSTDO5o= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-548-4OfPzVL8PVij4kbxJRxKKw-1; Tue, 21 Jan 2025 02:49:08 -0500 X-MC-Unique: 4OfPzVL8PVij4kbxJRxKKw-1 X-Mimecast-MFC-AGG-ID: 4OfPzVL8PVij4kbxJRxKKw Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38a2140a400so4061346f8f.0 for ; Mon, 20 Jan 2025 23:49:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737445747; x=1738050547; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pEWTOBE0YfA5NLzP4KdNTpkr07FskrCb/W5+adJSTLI=; b=rosjQjosKSQM2KVkHwYWinBZJRzuecQjU5HJVOAUe/gF7VXiwKfJnEHSB59tb9CgIT BZrEcyX4p70xH4hxnpxnqYbQwiOO2UQ0E8uQXJ0SFHB7wOzSM0JYVNzUGI4tAhYanY7b mpDQVxRCtTYFsVFHtEukgzEnbscVeMYxZ2R2POS6EWyw38zr3o3zmIqu3QCo4oVxToUA 4zddthhI+xCK3whx8nFTHP/CvFj/Edrzg9G10WmLQNq4usQSFp8U6OKZlz/9IdlWa4fo 5Lq+doH3EjZQh4x/a6TuJLu9U3zQaIZmhRfRYCauUCb7WLDRth9l6Dx+8+9/LFA14QEk Fo/Q== X-Forwarded-Encrypted: i=1; AJvYcCVYXuzAX1PAWFfLjY6zmY6ZXvNdJOqFQAculVu3/Zr1M8uoiCpQ89T22Rj8b+Bf8qCsguIGAZmkRGw2s/w=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9SC7TjdCOfZ1bmN8F3lVfNG11MCpVJM+GR9IiUtWlt8MqvFit ztEdgmjqPUArz9799uOeM1MU7W4k9XKNLzt9NTTQIP3JHbB05bOoczh5NvqbExpeShMQjEPaS/+ 9DQRoIxLfuImmZIj7il73Nlbijy0OkZOy49ZW8UELwzJN76HtIhyb8TueZQQXmw== X-Gm-Gg: ASbGnctHN/7Se3r/kLu8st+PUM5h3q9S/desSDmNFT6SQ7GPRucyvCKUIBK1siZrlX+ frqOfzCTHIsT6gDWSIgH1im+uC0wN47GR3DIPnq/DmoG908SF63gozyxG3bCgSE9T5WoZcRTDq2 W+dOkGvZI2cctFQi9GmjdU4Rr7/Qpm9dENsHq33yuBV78LKPnAVcB6owXJDC+/LthPNDRj5A8e+ IUczbmkljZ8L/MP/WXJqKZiEJbodXux+Ux2z3fGsPAqttFRIP0kzJQEYlJFn5Jg2b2KT3Rbl8vY ZEHlrfAFuYY1JMYsWCvtWJqwyEPR0V/DA2VFtRQzwHXLQcfUi/0MZc5jWPKMSel4UIXb8AbIsPJ rkubDTDH47HzEI5q2MSLRGg== X-Received: by 2002:adf:ef04:0:b0:385:f23a:2fe1 with SMTP id ffacd0b85a97d-38bf566f7c9mr11016945f8f.26.1737445747045; Mon, 20 Jan 2025 23:49:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IGzHEhQMANKQac8Qho0ClYfJCOl0n1h+CUlYADqWE59ZH5VVRLVP0S8q9br897Namh1jCaz0A== X-Received: by 2002:adf:ef04:0:b0:385:f23a:2fe1 with SMTP id ffacd0b85a97d-38bf566f7c9mr11016928f8f.26.1737445746685; Mon, 20 Jan 2025 23:49:06 -0800 (PST) Received: from ?IPV6:2003:cb:c709:6200:16ba:af70:999d:6a1a? (p200300cbc709620016baaf70999d6a1a.dip0.t-ipconnect.de. [2003:cb:c709:6200:16ba:af70:999d:6a1a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3221db2sm12368688f8f.29.2025.01.20.23.49.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 23:49:06 -0800 (PST) Message-ID: Date: Tue, 21 Jan 2025 08:49:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: gup: fix infinite loop within __get_longterm_locked To: Zhaoyang Huang Cc: "zhaoyang.huang" , Andrew Morton , Alistair Popple , John Hubbard , linux-mm@kvack.org, linux-kernel@vger.kernel.org, steve.kang@unisoc.com References: <20250120092604.3590285-1-zhaoyang.huang@unisoc.com> <4326b3f1-f99d-4be8-97fd-286c75358635@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 21.01.25 02:31, Zhaoyang Huang wrote: > On Tue, Jan 21, 2025 at 4:14 AM David Hildenbrand wrote: >> >> On 20.01.25 10:26, zhaoyang.huang wrote: >>> From: Zhaoyang Huang >>> >>> Infinite loop within __get_longterm_locked detected in an unique usage >>> of pin_user_pages where the VA's pages are all unpinnable(vm_ops->fault >>> function allocate pages via cma_alloc for hardware purpose and leave them >>> out of LRU) Fixing this by have 'collected' reflect the actual number> of pages in movable_folio_list. >> >> Maybe something like: >> >> " >> We can run into an infinite loop in __get_longterm_locked() when >> collect_longterm_unpinnable_folios() finds only folios that are isolated >> from the LRU or were never added to the LRU. This can happen when all >> folios to be pinned are never added to the LRU, for example when >> vm_ops->fault allocated pages using cma_alloc() and never added them to >> the LRU. >> >> We incorrectly update the "collected" variable even if nothing was >> collected. Fix it by incrementing "collected" only when we isolated a >> folio and added it to the list of folios to migrate. >> " >> >> I assume, long-term these things will not actually be folios, but pages, >> and we'll have to skip them in different code -- or assume they can be >> longterm pinned even on CMA because they are allocated by the CMA-owning >> driver. > Thanks for the commit message. will update them to v2 >> >>> >>> Signed-off-by: Zhaoyang Huang >>> --- >>> mm/gup.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/mm/gup.c b/mm/gup.c >>> index 3b75e631f369..2231ce7221f9 100644 >>> --- a/mm/gup.c >>> +++ b/mm/gup.c >>> @@ -2341,8 +2341,6 @@ static unsigned long collect_longterm_unpinnable_folios( >>> if (folio_is_longterm_pinnable(folio)) >>> continue; >>> >>> - collected++; >>> - >>> if (folio_is_device_coherent(folio)) >>> continue; >>> >>> @@ -2359,6 +2357,8 @@ static unsigned long collect_longterm_unpinnable_folios( >>> if (!folio_isolate_lru(folio)) >>> continue; >>> >>> + collected++; >>> + >>> list_add_tail(&folio->lru, movable_folio_list); >>> node_stat_mod_folio(folio, >>> NR_ISOLATED_ANON + folio_is_file_lru(folio), >> >> What if folio_isolate_hugetlb() succeeded? The return value can tell us >> if it actually succeeded. > How about remove the variable 'collected' and change the criteria to > if(list_empty(&movable_folio_list)) That works if we know that the input list is empty, which is the case. So let's turn that function into a void function, ans simply check list_empty() in the caller that prepares the empty list. -- Cheers, David / dhildenb