mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Stephen Langstaff <stephenlangstaff1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	linux-kernel@vger.kernel.org,
	"OlteanV@gmail.com" <OlteanV@gmail.com>
Subject: Re: drivers/net/dsa/dsa_loop_bdinfo.c build problems
Date: Mon, 13 May 2024 19:54:33 +0200	[thread overview]
Message-ID: <e307a237-68e3-40c9-be31-4fe3d560ada2@lunn.ch> (raw)
In-Reply-To: <CAHx5RXBFdzsgKXR94gdZd2b=uz8PJDg4OjLPJxKtsdhcjJq3Qw@mail.gmail.com>

On Mon, May 13, 2024 at 06:40:19PM +0100, Stephen Langstaff wrote:
> On Mon, May 13, 2024 at 5:54 PM Andrew Lunn <andrew@lunn.ch> wrote:
> > As Florian pointed out, dsa_loop_bdinfo.o should be built into your
> > kernel. When you insmod dsa_loop.ko, it should match the data in
> > dsa_loop_bdinfo to the dsa_loop driver an instantiate an instance of
> > it. Do you see that happening?
> 
> Well, if I fiddle with the Makefiles to get dsa_loop_bdinfo built as a
> module (as opposed to not building at all) then I see the following
> behaviour:
> 
> root@machine:~/dsa_test# ls
> dsa_loop.ko  dsa_loop_bdinfo.ko
> root@machine:~/dsa_test# modprobe dsa_core
> root@machine:~/dsa_test# insmod dsa_loop_bdinfo.ko
> root@machine:~/dsa_test# insmod dsa_loop.ko
> root@machine:~/dsa_test# lsmod
> Module                  Size  Used by
> dsa_loop               16384  0
> dsa_loop_bdinfo        16384  0
> dsa_core              118784  1 dsa_loop
> ...
> 
> ...and I see no new interfaces reported by ifconfig -a
> [just the existing eth0, eth1 and lo0 interfaces]
> 
> I will revert my changes to the Makefiles and confirm that
> dsa_loop_bdinfo.o does not get built into the kernel - that's an
> overnight build for me so bye for now!

I think most developer cross compile the kernel on a big machine. I
also tend to build in everything i need, so its all in one file, which
i get uboot to tftpboot. It makes the whole build/boot/crash cycle
much master.

     Andrew

  reply	other threads:[~2024-05-13 17:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13 15:33 Stephen Langstaff
2024-05-13 15:34 ` Florian Fainelli
2024-05-13 15:36   ` Stephen Langstaff
2024-05-13 15:40     ` Florian Fainelli
2024-05-13 15:45       ` Stephen Langstaff
2024-05-13 15:50         ` Florian Fainelli
2024-05-13 16:21           ` Stephen Langstaff
2024-05-13 16:54             ` Andrew Lunn
2024-05-13 17:40               ` Stephen Langstaff
2024-05-13 17:54                 ` Andrew Lunn [this message]
     [not found]                   ` <CAHx5RXCF0=Soz_k88RGvJFGrajaxn=mVnqpb99GAQ=b7XOcWiw@mail.gmail.com>
2024-05-13 19:05                     ` Florian Fainelli
2024-05-14  9:28                       ` Stephen Langstaff
2024-05-14 12:32                         ` Andrew Lunn
2024-05-14 16:08                           ` Stephen Langstaff
2024-05-14 16:17                             ` Andrew Lunn
2024-05-15  4:05                               ` Florian Fainelli
2024-05-15 19:20                                 ` Florian Fainelli
2024-05-16  2:17                                   ` Masahiro Yamada
2024-05-16  3:35                                     ` Florian Fainelli
2024-05-16  6:39                                       ` Masahiro Yamada
2024-05-15  9:23                               ` Stephen Langstaff
2024-05-15 19:26                                 ` Florian Fainelli
2024-05-16  9:27                                   ` Stephen Langstaff
  -- strict thread matches above, loose matches on Subject: below --
2024-05-13 14:43 Stephen Langstaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e307a237-68e3-40c9-be31-4fe3d560ada2@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=OlteanV@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stephenlangstaff1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®