From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17DCAC433EF for ; Wed, 23 Feb 2022 03:58:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237992AbiBWD6k (ORCPT ); Tue, 22 Feb 2022 22:58:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231979AbiBWD6i (ORCPT ); Tue, 22 Feb 2022 22:58:38 -0500 Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91E684CD77 for ; Tue, 22 Feb 2022 19:58:11 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id EE53B5801D0; Tue, 22 Feb 2022 22:58:10 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 22 Feb 2022 22:58:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; bh=JMnTWrM6JKgfkr GrFGJeArt2hBYEa8agk9uD7BDHbyI=; b=V/ehg4cp+DYJvWZyUIhLRI9Q0+0Lto 5xT1uq5pyG+iBq4DhutDRT2923luPDAUeowdRjykTVpXvRsfHzxmDW5iPYD43M9J CVL6EMsFXz6VESxEYP1VJeDEnA3L9WSCh6K2JeKxdyxXNdZjzSbDvCG8O3UQIMll OxLf3/CZlCzhO5eT91eRiM4fvg4bWX9G1LVg+AFZT7A+VSnruip9RyK2ritOpn36 hDHqsjekp0g5E/4fU0o85zplx5AA6Wrur7+zGoIjRqLyFd6O6/Fo2bEBCdGg0ktv W6H2mCJUlGJEZQmv6E1NK4nCiTdfEOos+01/9UaeUyDgMZFeanKiuZvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=JMnTWrM6JKgfkrGrFGJeArt2hBYEa8agk9uD7BDHb yI=; b=QpX+wfTThxe76ooL3wyB3aRq94MnFypg/bIbZQeaVnI9kLnvotdVMuak8 Cea3G1/qj4wqctujBqrzx/lwNCiOi+UBpczHZBPSHhuZvVXiXZj6diXla5N8DMtV WSqRLzsqFZshBtP/d/tU6kz9KVzH9wU0m4Hc/du6yY6e9b9yj7+Nnu8qmBfSpFwk 6mxh9b2u6jcM/5NBllMugT2cu9kOIsDk90HHFQW+Hni3jgVjUbC8mKi3cRMXWuRa gC1U/WnR1N7ZFMPDWYCkzN8vlyILG5Y/S4LzEg2G7TFX8kGCvd9Mfph/sBUtqpD0 tGoclawcq9Q/JCEY6p229Ch5xt55w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeelgdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefurghmuhgv lhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenucggtf frrghtthgvrhhnpefgveffteelheffjeeukedvkedviedtheevgeefkeehueeiieeuteeu gfettdeggeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Feb 2022 22:58:10 -0500 (EST) Subject: Re: [PATCH v10 15/18] phy: sun4i-usb: Add support for the H616 USB PHY To: Andre Przywara , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec Cc: Rob Herring , Ondrej Jirman , Icenowy Zheng , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , linux-phy@lists.infradead.org References: <20220211122643.1343315-1-andre.przywara@arm.com> <20220211122643.1343315-16-andre.przywara@arm.com> From: Samuel Holland Message-ID: Date: Tue, 22 Feb 2022 21:58:09 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20220211122643.1343315-16-andre.przywara@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/22 6:26 AM, Andre Przywara wrote: > The USB PHY used in the Allwinner H616 SoC inherits some traits from its > various predecessors: it has four full PHYs like the H3, needs some > extra bits to be set like the H6, and puts SIDDQ on a different bit like > the A100. Plus it needs this weird PHY2 quirk. > > Name all those properties in a new config struct and assign a new > compatible name to it. > > Signed-off-by: Andre Przywara Reviewed-by: Samuel Holland