From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9231EDE98F for ; Thu, 14 Sep 2023 08:01:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235937AbjINIBj (ORCPT ); Thu, 14 Sep 2023 04:01:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236073AbjINIBd (ORCPT ); Thu, 14 Sep 2023 04:01:33 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8897B1FC0 for ; Thu, 14 Sep 2023 01:01:29 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-401ec23be82so6887515e9.0 for ; Thu, 14 Sep 2023 01:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694678488; x=1695283288; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=neHhhzHlruzM/bvrwbdgCTOdYr0CjWOhZQjc/HyIrV8=; b=ytX8ohi/O3UPOQQi9W8ghuKqmcStYEagdhfO8nUAc+R+H+DAJxz9VR1X92j1wBKkEy nC6+6pHzBKc4t5Bfdszaju10fCvDnWoX1V7Hm/HLga8PPoABErBki177GZC1QaG9mCtF crpxYmTSKsAkLAnerMDWb09pDB1BoAU2ZrwRZHszeouJSf/4nfaEsuFFRpMj4lubPWqS f53WLOhklK/uc9xm0/tRc2S6oNvbkB8MFrmaulq1mS5RY/TVQfLjcYDTQoiet5cx6ns9 ehobsAw6UwB7f2EtEO3Ble8dtnN7DPOKfcklRNHNMLgnm8650xXN9MfBJc79YczCoSgj Q8Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694678488; x=1695283288; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=neHhhzHlruzM/bvrwbdgCTOdYr0CjWOhZQjc/HyIrV8=; b=lwLCtgTLlafDEK2N14GbOYt+I/6RJMgICVQioSysQM8H+01rMky7KOqEJJTqbUFT1I 4F7A0o1CcDz2XYxa8HLYUL2lQ/HDG8B1afJ1CQYhbK915Bv4J7zdipIjYd1atbjOFPUQ j5G2jCqL00jPYZ86lRDBa7vkbIhpJYJBkj1c51u6Cpr1ciLAd930LE8qg8wdsPYM5Jjs hz/Bzyo+EPRW0mKthIOBINF6LTXVhENejHNZ4sFfYVcdG+bRu4Nk5sFe8wBKlZxdHEUb f4wXURA8Su+LOI/RPXlSRlPZvK+bLy46LdRaYQWe/N1ESLLFcSlEBEQNMpoEfsQBHQ32 RIng== X-Gm-Message-State: AOJu0YyOt7HGosmoIoh3Hi4t9KL1SrjA8GULicx7KSQmJRmA1+mRQY2d iAgqOfQGsI3M662eXsFMGXuXWEuVBSx2o5EMWK8= X-Google-Smtp-Source: AGHT+IFso3OC//te/RXHvw1AW0IiU72BrrwKpr4DwwZ5HlU8y8W3tOtFzamFowjrziqS++NJdjIMFA== X-Received: by 2002:a05:600c:219:b0:3fe:f45:772d with SMTP id 25-20020a05600c021900b003fe0f45772dmr3841053wmi.28.1694678487884; Thu, 14 Sep 2023 01:01:27 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id v26-20020a1cf71a000000b003fe1630a8f0sm4126065wmh.24.2023.09.14.01.01.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Sep 2023 01:01:25 -0700 (PDT) Message-ID: Date: Thu, 14 Sep 2023 10:01:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2] ARM: dts: exynos: enable polling in Exynos 4210 Content-Language: en-US To: Mateusz Majewski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Marek Szyprowski References: <20230911133417.14042-1-m.majewski2@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20230911133417.14042-1-m.majewski2@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09/2023 15:34, Mateusz Majewski wrote: > It seems that thermal in Exynos 4210 is broken without this, as it will > never decrease cooling after increasing it. > > Signed-off-by: Mateusz Majewski > --- > v1 -> v2: Just uploaded separately from all the thermal: exynos: > patches with a shorter recipient list, no change otherwise. > > arch/arm/boot/dts/samsung/exynos4210.dtsi | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi > index 0e27c3375e2e..aae185b7f91c 100644 > --- a/arch/arm/boot/dts/samsung/exynos4210.dtsi > +++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi > @@ -391,8 +391,14 @@ &cpu_alert2 { > }; > > &cpu_thermal { > - polling-delay-passive = <0>; > - polling-delay = <0>; > + /* Exynos 4210 supports thermal interrupts, but only for the rising threshold. This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. I fixed it up and applied. Best regards, Krzysztof