From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABFBC26463A for ; Thu, 20 Nov 2025 12:32:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763641934; cv=none; b=Njh0nBeLjHDUze4wvzA9zuuxFL7S8tmx8A8aABCQwQTNg09/4IwWwx52a6nIWK3bHvw7YWSu4w/bPVT6e8mVxGhlLfr6v5+5WW18YBIeJok7vVkhK+J2/3i6xNtNiFkRvCesgggkqbDMBxjjGJtHmDcV/li1sr0KqhZ7ov8aD18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763641934; c=relaxed/simple; bh=a/PRqwHCM3ePs6OGfOUCvop0NTpl4VFk2TuFv1Vo9l8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G8Syopd3RO3fBgA1jjwHvfX+ufgSinhcnOXH613GxeIsW9PYYatpBIfycxpqLKpEX0e2JMpmsEcgj98xhQHyC3S/sQKsj8za4F1IIA3pBzYhXrnmbQ0EMMWHrn80sAl4+KzpCTDk9/HmaDwg4y3u0MdmQtGTuwg1y6HH68xHvDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dymA/iJ+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=TS29kyG0; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dymA/iJ+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="TS29kyG0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763641930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6u/B0hyLbYqyZMSxsyCVEeXGSKwBFnSMtY/RgygB0IM=; b=dymA/iJ+d+E0UXH8HaPsCd/BeTrM33Lac65ewQNRPap6ucMO+Ufz7hoj2IaxI5HjSZ070A q/bV/UXDP/C1+gGKpwD9DPs020bjg57kjPWcUjxHxrWXUaTx1vf4hWQNiYRIFASoV2PRS6 aZ5ks+4hxdWM2KpoEqec65wbIq+RA/U= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-313-dpTwZYRRPAGTIfys-XoVxA-1; Thu, 20 Nov 2025 07:32:08 -0500 X-MC-Unique: dpTwZYRRPAGTIfys-XoVxA-1 X-Mimecast-MFC-AGG-ID: dpTwZYRRPAGTIfys-XoVxA_1763641928 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-89eb8ee2a79so514669285a.2 for ; Thu, 20 Nov 2025 04:32:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1763641928; x=1764246728; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6u/B0hyLbYqyZMSxsyCVEeXGSKwBFnSMtY/RgygB0IM=; b=TS29kyG09opwKuqN/fKV6BCM/qaJTVa5dWvefLwT/EoWvocgIP8105IQyOHkndtMPY OYbz/jjHpI2EPn1AT6nC1QBltOFZiyj3DUXg/GENLHonfs+yYGvLZ/mCUjclSTeL0VyZ oyeOHJGm9u+PhBR9HxBCipxWfXMklArZnto/xnClzHrLAlgU3ATMNXIl4H7v3R+SmzUB c6KA0iCIDDzG8/5HTjstk9VPcf04QTz63l39xc9waoIj079XmNyi2oLfuPeeMQEpc9u4 QkacjXxQLB09ikBg6ta8avdyCtAxr+rno8Xmel+v4UzN9gCjkOOp4FBLkDM6vUmSJgy8 yC9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763641928; x=1764246728; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6u/B0hyLbYqyZMSxsyCVEeXGSKwBFnSMtY/RgygB0IM=; b=lTi6TXn2fEJcB49H1OBK02W7lmSQjfXUbl4F7dGSRHccmO04a7l7OaYK76sGStlx+c WgFoyy5/KLlDZyU7qVd3DYF6eXzDGjrPesebbKyHESY2RbJ0PmKXZNLnDLfGCjkOiDS6 fVPYzsLjKy2jwfVIzmbgtM6uhIGV0Ye1cCob9qJgfwn8DCmjx4qt3p5CmrLT0FFZHjNJ V7jKNpnWe+YG1jcZR1zkGdM0aUEmvPqp5h8wEjeEQfFp4B3ZcZw/bRMxEbWp7zIQrFhj fJmD+kQF09iW/fJd8pPUjvLZjCLNn7rWVcq6oSmekxMWIEiHW8ZRpQKrWLrnUKeDrQEe y3Ug== X-Gm-Message-State: AOJu0YyIo8wSTmoXaioaNYvi0FnaJwMQS1HblMNJ1Lq8ZgbOlmZcq/SW +yQdPeRRfW+WANX+4F6w2CnBW1R/wivI3xFy5kWazdCAGVSy5jUn60QVMJPlu4WIagizkYgjpVV S8J1Quo07DaXPI1YfoQJXoS5r3lmttlfp9RtqjWnZuLp2cgXOyjx8S/irh2JUwDcAhQ== X-Gm-Gg: ASbGncvL9yo1i6KqqV9Jd4qy5zBWltpunt/ubKcdGNmOoRE4NradkmzebNZQgPIix+L xrQ6C6T+ebpR5Ke5n/5QpIyGQWCn3A3l2ESXapXf+uFNcyTV1icq/LBKKJUsnvANluoC33Aif5L 7VRjaK4u7AsSaJM6wElM7Tvi0EFK7mhNGr8IpZitzt30KZe+xZdfGIP3QdedIkO1FE6/fbGP6OP xGOQvzw+zP8OavCtRnR13YRlQb1aUqH+y9/m6p++eO90VjoZGKNGXgzwsnL8hnkT0LyZ9KjReSY vUtbFJ/dFDLE4XcHTwd8Ubf2uv3jzRsEPYCEK00yb+TuFZ1DmOZYYxQzQp9kNnRct/a0DIkdW8a P9E51U7RRuA== X-Received: by 2002:a05:620a:4510:b0:89e:c659:3f99 with SMTP id af79cd13be357-8b3271f3b97mr408120085a.6.1763641928007; Thu, 20 Nov 2025 04:32:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEQ/LqEz04B/HpHsjuRcrpYuYfHMx1VrNW1buaRB4EKjlwSgxldECJxxjLXOdZZILs6q2TrA== X-Received: by 2002:a05:620a:4510:b0:89e:c659:3f99 with SMTP id af79cd13be357-8b3271f3b97mr408115185a.6.1763641927469; Thu, 20 Nov 2025 04:32:07 -0800 (PST) Received: from [10.26.1.94] ([66.187.232.136]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b3295c32fbsm142408185a.33.2025.11.20.04.32.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Nov 2025 04:32:06 -0800 (PST) Message-ID: Date: Thu, 20 Nov 2025 07:32:06 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] intel_th: core: fix null pointer dereference in intel_th_irq To: Markus Elfring , kernel-janitors@vger.kernel.org, Alexander Shishkin Cc: LKML , Jerry Hoemann References: <20251118212106.541728-1-darcari@redhat.com> <32755d36-050e-413f-93b9-55d8306c165d@web.de> Content-Language: en-US From: David Arcari In-Reply-To: <32755d36-050e-413f-93b9-55d8306c165d@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 11/19/25 7:55 AM, Markus Elfring wrote: >> In certain cases intel_th_irq can reference a null entry in >> the th->thdev array. This results in the splat shown below. >> The problem is that intel_th_output_enable() can modify the >> thdev[] array at the same time intel_th_irq is referencing >> the same array. This can be fixed by disabling interrupts >> during the call to intel_th_output_enable(). > > 1. Would another imperative wording become helpful for an improved change description? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc6#n94 I feel like the description explains the problem well. However, do you have alternate wording you would like to suggest? > > 2. You may occasionally put more than 60 characters into text lines > of such a change description. I can redo the body of the commit and submit a v3 if the maintainer is interested in applying a patch of this nature. > > 3. Would a summary phrase like “Prevent null pointer dereference > in intel_th_output_enable()” be more appropriate? The null pointer deference occurs in intel_th_irq. So I could change it to "Prevent null pointer dererference in intel_th_irq". Before I do anything else with this patch I'd like to hear back from Alexander. There's no reason to refactor a patch that won't be committed. Thanks, -DA > > > Regards, > Markus >