From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16BB914E2E9 for ; Tue, 2 Jul 2024 09:20:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719912022; cv=none; b=Q0p6fxnXptQgkNLkFbUbX2vhk83WcWNW/a8t/wLKbn5is482SX0Whow9xIKuUbNXfFuuWCB8r8uzkhnFhAmK8iDdK+60LYTK2kNx7NxFXlj6XzIZ+6F/HMDrZB0+CJ20sS1LraKUAMIDDVjSLqfAib94uLFmZkK64iYVVPCwrr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719912022; c=relaxed/simple; bh=FBGGUF9yGhtpSD7KFZanwXm4og4Pep/4VZR5qRW1nRQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NkG7+gJBEMJYCJMUNZvpx/wfyl4wn6kWjG5ztlanxo/Q/POa6z9PXeXiMaiXWmeHbHAyDk1Yb1/iLP68F+YAELcoi8HeQ9CJSU01rNN1U8FLMVtNLz05u5ILYT9+iZTgNgRulnDdKKosNHi2FFB4Tr/SxB1jfxoGjyRMyoFDNxg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=BnZ7BS3Y; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="BnZ7BS3Y" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-57cc1c00ba6so1732354a12.1 for ; Tue, 02 Jul 2024 02:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1719912017; x=1720516817; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Am5AKU5CYVlzXMlBULleGZdt7dqJl3EdYaCR7jwAFu8=; b=BnZ7BS3YbfR7DKAmnawPycgH0Yr1Ua7Mmww1jXxzJT2cYDi/PuCVRbe5iRKO6uTJWF mQVkrTKjc3UdJN8M7uFFZPoeqGbQn5VGDeVGk/VQP2qZmDQnBb/JsUbCw6mAVJAqucd8 6MGtb+CSl2kF4cp3Qo/pAoSfQR2dSoZaRP4WLLd/kPP1vCH7KMAN/Q+YAr6OWzCPFCz1 pT7qEPMOUhcrAdsiyjQyggEJdo2tMqsSJYN6R/p5hGc0jqNEqNfnKGIz05s4D7P+Mkwb uiL7d1a8M1VG3twpPn5Td2bu9hNsDCDkg98VSk+pYBYqZInnbzJwne4Rm5rpXFYSqNRF fdBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719912017; x=1720516817; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Am5AKU5CYVlzXMlBULleGZdt7dqJl3EdYaCR7jwAFu8=; b=hVLLKlInSucrvLs7w16GBF4sW3lTmli2CNQeVQOMTCmK6EuNYVjAiNRh1uo9H4Q5+6 d/hqhGprQVGF1eQCVQ8q1cxk3OZ3Ih+AxxapT5XJ4mE6drfQ9W61NUahN50S6ICD7QNP zDCRD6WW/YylVSh8+wiTNlyr+ufIX3RcdeMeBJaxbW1qid6kpDuHaad42zGOHicvrNxz 53zVqwaHeqNsDoPABey28K4Yqhejoh9vSV1OodcF7EjVNcDvAsMAVJpMSotDNCqtl5dl wRJePGEp9V9qORyT77X/xmqFY/+KCIcFjm7VGcTqjcmcihVWPHYOIqtna5sRq+yGFQ1J GMUg== X-Forwarded-Encrypted: i=1; AJvYcCX0cCRrelHlKheUq5WqxcuG7ZBsSbWLCZIzbfJ0bxK+Qse2Rao+i9FQPSUXej+XtsRr5V/ppiTwdO5mRCj0GWpH0eSCTY6xIISPj/yr X-Gm-Message-State: AOJu0YzvbtcP1IcZLUJWt39tIcqycdeyQ6qZ8qdcsVHBmM1dCly8CXt5 5z5cB+Nf7YE1hScEykjyfoDUtlj8i7nFceVbtrglhjgRIO76Js/Pxf+63GY6DHI= X-Google-Smtp-Source: AGHT+IEoCb87+tFLwRVVwSSbEyVxUK6Qfov0xOk39+vIaDdYOByLb4JEhPWggGYmh2GtQFsbWQdvgw== X-Received: by 2002:a05:6402:2786:b0:582:7e6d:6816 with SMTP id 4fb4d7f45d1cf-5879f0c6348mr5915930a12.8.1719912017377; Tue, 02 Jul 2024 02:20:17 -0700 (PDT) Received: from ?IPV6:2003:e5:8729:4000:29eb:6d9d:3214:39d2? (p200300e58729400029eb6d9d321439d2.dip0.t-ipconnect.de. [2003:e5:8729:4000:29eb:6d9d:3214:39d2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58614d50464sm5374524a12.69.2024.07.02.02.20.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jul 2024 02:20:17 -0700 (PDT) Message-ID: Date: Tue, 2 Jul 2024 11:20:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen: add missing MODULE_DESCRIPTION() macros To: Jeff Johnson , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20240611-md-drivers-xen-v1-1-1eb677364ca6@quicinc.com> <2ecfd10e-c8f2-458c-bf07-e4472d22bcfe@quicinc.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= In-Reply-To: <2ecfd10e-c8f2-458c-bf07-e4472d22bcfe@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26.06.24 18:46, Jeff Johnson wrote: > On 6/11/2024 4:54 PM, Jeff Johnson wrote: >> With ARCH=x86, make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/xen/xen-pciback/xen-pciback.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/xen/xen-evtchn.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/xen/xen-privcmd.o >> >> Add the missing invocations of the MODULE_DESCRIPTION() macro. >> >> Signed-off-by: Jeff Johnson >> --- >> Corrections to these descriptions are welcomed. I'm not an expert in >> this code so in most cases I've taken these descriptions directly from >> code comments, Kconfig descriptions, or git logs. History has shown >> that in some cases these are originally wrong due to cut-n-paste >> errors, and in other cases the drivers have evolved such that the >> original information is no longer accurate. >> --- >> drivers/xen/evtchn.c | 1 + >> drivers/xen/privcmd-buf.c | 1 + >> drivers/xen/privcmd.c | 1 + >> drivers/xen/xen-pciback/pci_stub.c | 1 + >> 4 files changed, 4 insertions(+) >> >> diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c >> index f6a2216c2c87..9b7fcc7dbb38 100644 >> --- a/drivers/xen/evtchn.c >> +++ b/drivers/xen/evtchn.c >> @@ -729,4 +729,5 @@ static void __exit evtchn_cleanup(void) >> module_init(evtchn_init); >> module_exit(evtchn_cleanup); >> >> +MODULE_DESCRIPTION("Xen /dev/xen/evtchn device driver"); >> MODULE_LICENSE("GPL"); >> diff --git a/drivers/xen/privcmd-buf.c b/drivers/xen/privcmd-buf.c >> index 2fa10ca5be14..0f0dad427d7e 100644 >> --- a/drivers/xen/privcmd-buf.c >> +++ b/drivers/xen/privcmd-buf.c >> @@ -19,6 +19,7 @@ >> >> #include "privcmd.h" >> >> +MODULE_DESCRIPTION("Xen Mmap of hypercall buffers"); >> MODULE_LICENSE("GPL"); >> >> struct privcmd_buf_private { >> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c >> index 67dfa4778864..b9b784633c01 100644 >> --- a/drivers/xen/privcmd.c >> +++ b/drivers/xen/privcmd.c >> @@ -48,6 +48,7 @@ >> >> #include "privcmd.h" >> >> +MODULE_DESCRIPTION("Xen hypercall passthrough driver"); >> MODULE_LICENSE("GPL"); >> >> #define PRIV_VMA_LOCKED ((void *)1) >> diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c >> index e34b623e4b41..4faebbb84999 100644 >> --- a/drivers/xen/xen-pciback/pci_stub.c >> +++ b/drivers/xen/xen-pciback/pci_stub.c >> @@ -1708,5 +1708,6 @@ static void __exit xen_pcibk_cleanup(void) >> module_init(xen_pcibk_init); >> module_exit(xen_pcibk_cleanup); >> >> +MODULE_DESCRIPTION("Xen PCI-device stub driver"); >> MODULE_LICENSE("Dual BSD/GPL"); >> MODULE_ALIAS("xen-backend:pci"); >> >> --- >> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 >> change-id: 20240611-md-drivers-xen-522fc8e7ef08 >> > > Following up to see if anything else is needed from me. Hoping to see this in > linux-next so I can remove it from my tracking spreadsheet :) I've pushed the patch to the xen/tip.git for-next branch. Juergen