From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1199C31E40 for ; Wed, 7 Aug 2019 00:31:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90B73214C6 for ; Wed, 7 Aug 2019 00:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727557AbfHGAb3 (ORCPT ); Tue, 6 Aug 2019 20:31:29 -0400 Received: from ale.deltatee.com ([207.54.116.67]:50098 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726381AbfHGAb3 (ORCPT ); Tue, 6 Aug 2019 20:31:29 -0400 Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtp (Exim 4.89) (envelope-from ) id 1hv9rD-0003gV-OL; Tue, 06 Aug 2019 18:31:12 -0600 To: Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, Sagi Grimberg , Christian Koenig , Jens Axboe , Keith Busch , Jason Gunthorpe , Stephen Bates , Dan Williams , Eric Pilmore , Christoph Hellwig References: <20190730163545.4915-1-logang@deltatee.com> <20190806234439.GW151852@google.com> From: Logan Gunthorpe Message-ID: Date: Tue, 6 Aug 2019 18:31:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190806234439.GW151852@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: hch@lst.de, epilmore@gigaio.com, dan.j.williams@intel.com, sbates@raithlin.com, jgg@mellanox.com, kbusch@kernel.org, axboe@fb.com, Christian.Koenig@amd.com, sagi@grimberg.me, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, helgaas@kernel.org X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v2 00/14] PCI/P2PDMA: Support transactions that hit the host bridge X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-08-06 5:44 p.m., Bjorn Helgaas wrote: > On Tue, Jul 30, 2019 at 10:35:31AM -0600, Logan Gunthorpe wrote: >> Here's v2 of the patchset. It doesn't sound like there's anything >> terribly controversial here so this version is mostly just some >> cleanup changes for clarity. >> >> Changes in v2: >> * Rebase on v5.3-rc2 (No changes) >> * Re-introduce the private pagemap structure and move the p2p-specific >> elements out of the commond dev_pagemap (per Christoph) >> * Use flags instead of bool in the whitelist (per Jason) >> * Only store the mapping type in the xarray (instead of the distance >> with flags) such that a function can return the mapping method >> with a switch statement to decide how to map. (per Christoph) >> * Drop find_parent_pci_dev() on the fast path and rely on the fact >> that the struct device passed to the mapping functions *must* be >> a PCI device and convert it directly. (per suggestions from >> Christoph and Jason) >> * Collected Christian's Reviewed-by's >> -- >> >> As discussed on the list previously, in order to fully support the >> whitelist Christian added with the IOMMU, we must ensure that we >> map any buffer going through the IOMMU with an aprropriate dma_map >> call. This patchset accomplishes this by cleaning up the output of >> upstream_bridge_distance() to better indicate the mapping requirements, >> caching these requirements in an xarray, then looking them up at map >> time and applying the appropriate mapping method. >> >> After this patchset, it's possible to use the NVMe-of P2P support to >> transfer between devices without a switch on the whitelisted root >> complexes. A couple Intel device I have tested this on have also >> been added to the white list. >> >> Most of the changes are contained within the p2pdma.c, but there are >> a few minor touches to other subsystems, mostly to add support >> to call an unmap function. >> >> The final patch in this series demonstrates a possible >> pci_p2pdma_map_resource() function that I expect Christian will need >> but does not have any users at this time so I don't intend for it to be >> considered for merging. > > I don't see pci_p2pdma_map_resource() in any of these patches. Oh, sorry, I removed that in v2 seeing there was some confusion over it. I guess I forgot to remove the reference in the cover letter. > I tentatively applied these to pci/p2pdma with minor typographical > updates (below), but I'll update the branch if necessary. Great, thanks! The typographical changes look good. I already have one very minor change queued up for these. Should I just send you a small patch against your branch for you to squash? Logan