From: "Naik, Avadhut" <avadnaik@amd.com>
To: Yazen Ghannam <yazen.ghannam@amd.com>,
bp@alien8.de, tony.luck@intel.com, linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, avadhut.naik@amd.com, john.allen@amd.com
Subject: Re: [PATCH] RAS/AMD/FMPM: Add option to ignore CEs
Date: Mon, 6 Oct 2025 11:35:29 -0500 [thread overview]
Message-ID: <e3209aea-19cd-4577-b557-842176cbb7b4@amd.com> (raw)
In-Reply-To: <20251006151731.1885098-1-yazen.ghannam@amd.com>
On 10/6/2025 10:17, Yazen Ghannam wrote:
> Generally, FMPM will handle all memory errors as it is expected that
> "upstream" entities, like hardware thresholding or other Linux notifier
> blocks, will filter out errors.
>
> However, some users prefer that correctable errors are not filtered out
> but only that FMPM does not take action on them.
>
> Add a module parameter to ignore correctable errors.
>
> When set, FMPM will not retire memory nor will it save FRU records for
> correctable errors.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> ---
> drivers/ras/amd/fmpm.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c
> index 8877c6ff64c4..08b16a133f20 100644
> --- a/drivers/ras/amd/fmpm.c
> +++ b/drivers/ras/amd/fmpm.c
> @@ -129,6 +129,14 @@ static struct dentry *fmpm_dfs_entries;
> GUID_INIT(0x5e4706c1, 0x5356, 0x48c6, 0x93, 0x0b, 0x52, 0xf2, \
> 0x12, 0x0a, 0x44, 0x58)
>
> +/**
> + * DOC: ignore_ce (bool)
> + * Switch to handle or ignore correctable errors.
> + */
> +static bool ignore_ce;
> +module_param(ignore_ce, bool, 0644);
> +MODULE_PARM_DESC(ignore_ce, "Ignore correctable errors");
> +
> /**
> * DOC: max_nr_entries (byte)
> * Maximum number of descriptor entries possible for each FRU.
> @@ -413,6 +421,9 @@ static int fru_handle_mem_poison(struct notifier_block *nb, unsigned long val, v
> if (!mce_is_memory_error(m))
> return NOTIFY_DONE;
>
> + if (ignore_ce && mce_is_correctable(m))
> + return NOTIFY_DONE;
> +
> retire_dram_row(m->addr, m->ipid, m->extcpu);
>
> /*
>
> base-commit: fd94619c43360eb44d28bd3ef326a4f85c600a07
LGTM!
Reviewed-by: Avadhut Naik <avadhut.naik@amd.com>
--
Thanks,
Avadhut Naik
next prev parent reply other threads:[~2025-10-06 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 15:17 Yazen Ghannam
2025-10-06 16:35 ` Naik, Avadhut [this message]
2025-10-06 21:34 ` Borislav Petkov
2025-10-07 14:56 ` Yazen Ghannam
2025-10-07 16:52 ` Luck, Tony
2025-10-07 17:38 ` Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3209aea-19cd-4577-b557-842176cbb7b4@amd.com \
--to=avadnaik@amd.com \
--cc=avadhut.naik@amd.com \
--cc=bp@alien8.de \
--cc=john.allen@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®