From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE3C3C433B4 for ; Wed, 28 Apr 2021 03:06:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A507A61154 for ; Wed, 28 Apr 2021 03:06:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235506AbhD1DH3 (ORCPT ); Tue, 27 Apr 2021 23:07:29 -0400 Received: from foss.arm.com ([217.140.110.172]:59724 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230285AbhD1DH2 (ORCPT ); Tue, 27 Apr 2021 23:07:28 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B12A1FB; Tue, 27 Apr 2021 20:06:44 -0700 (PDT) Received: from [10.163.76.81] (unknown [10.163.76.81]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5505C3F694; Tue, 27 Apr 2021 20:06:34 -0700 (PDT) From: Anshuman Khandual Subject: Re: [PATCH 2/5] mm/huge_memory.c: use page->deferred_list To: Miaohe Lin , akpm@linux-foundation.org Cc: ziy@nvidia.com, william.kucharski@oracle.com, willy@infradead.org, yang.shi@linux.alibaba.com, aneesh.kumar@linux.ibm.com, rcampbell@nvidia.com, songliubraving@fb.com, kirill.shutemov@linux.intel.com, riel@surriel.com, hannes@cmpxchg.org, minchan@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210427133214.2270207-1-linmiaohe@huawei.com> <20210427133214.2270207-3-linmiaohe@huawei.com> Message-ID: Date: Wed, 28 Apr 2021 08:37:26 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210427133214.2270207-3-linmiaohe@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/27/21 7:02 PM, Miaohe Lin wrote: > Now that we can represent the location of ->deferred_list instead of > ->mapping + ->index, make use of it to improve readability. Could you please explain how page->deferred_list and page->mapping are interchangeable here ? > > Signed-off-by: Miaohe Lin > --- > mm/huge_memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 63ed6b25deaa..76ca1eb2a223 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2868,7 +2868,7 @@ static unsigned long deferred_split_scan(struct shrinker *shrink, > spin_lock_irqsave(&ds_queue->split_queue_lock, flags); > /* Take pin on all head pages to avoid freeing them under us */ > list_for_each_safe(pos, next, &ds_queue->split_queue) { > - page = list_entry((void *)pos, struct page, mapping); > + page = list_entry((void *)pos, struct page, deferred_list); > page = compound_head(page); > if (get_page_unless_zero(page)) { > list_move(page_deferred_list(page), &list); > @@ -2883,7 +2883,7 @@ static unsigned long deferred_split_scan(struct shrinker *shrink, > spin_unlock_irqrestore(&ds_queue->split_queue_lock, flags); > > list_for_each_safe(pos, next, &list) { > - page = list_entry((void *)pos, struct page, mapping); > + page = list_entry((void *)pos, struct page, deferred_list); > if (!trylock_page(page)) > goto next; > /* split_huge_page() removes page from list on success */ >