mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Robert Hancock <robert.hancock@calian.com>,
	Doug Berger <opendmb@gmail.com>,
	 Florian Fainelli <florian.fainelli@broadcom.com>,
	Breno Leitao <leitao@debian.org>
Subject: Re: netpoll:  raspberrypi [4 5]  driver locking woes
Date: Tue, 26 Aug 2025 11:49:27 +0200	[thread overview]
Message-ID: <e32a52852025d522f44d9d6ccc88c716ff432f8f.camel@gmx.de> (raw)
In-Reply-To: <4698029bbe7d7a33edd905a027e3a183ac51ad8a.camel@gmx.de>

On Mon, 2025-08-25 at 07:53 +0200, Mike Galbraith wrote:
> 
> On the pi4, lockdep muttered about ring->lock in bcmgenet_xmit() and
> bcmgenet_tx_poll() - switching to irqsave/restore spinlock variants
> there silenced it.

I went ahead and submitted the pi4 patchlet.

The pi5 gripe fix is equally trivial, but submitting that is pointless
given there's something else amiss in fingered commit.  This is all of
the crash info that escapes the box w/wo gripes silenced.

[   51.688868] sysrq: Trigger a crash
[   51.688892] Kernel panic - not syncing: sysrq triggered crash
[   51.698066] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 6.17.0-rc2-v8-lockdep #533 PREEMPTLAZY
[   51.707234] Hardware name: Raspberry Pi 5 Model B Rev 1.0 (DT)
[   51.713085] Call trace:
[   51.715532]  show_stack+0x20/0x38 (C)
[   51.719206]  dump_stack_lvl+0x38/0xd0
[   51.722878]  dump_stack+0x18/0x28

That aspect is a punt and run atm (time.. and dash of laziness:).

	-Mike

      parent reply	other threads:[~2025-08-26  9:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25  5:53 Mike Galbraith
2025-08-25 10:10 ` Mike Galbraith
2025-08-26  9:49 ` Mike Galbraith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e32a52852025d522f44d9d6ccc88c716ff432f8f.camel@gmx.de \
    --to=efault@gmx.de \
    --cc=florian.fainelli@broadcom.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=robert.hancock@calian.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®