From: Jinjie Ruan <ruanjinjie@huawei.com>
To: John Ogness <john.ogness@linutronix.de>, <pmladek@suse.com>,
<rostedt@goodmis.org>, <senozhatsky@chromium.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] printk: Use the BITS_PER_LONG macro
Date: Tue, 3 Sep 2024 11:39:27 +0800 [thread overview]
Message-ID: <e333684b-6833-fb62-2c6e-480f14333f8a@huawei.com> (raw)
In-Reply-To: <87y14auulz.fsf@jogness.linutronix.de>
On 2024/9/2 20:07, John Ogness wrote:
> On 2024-09-02, Jinjie Ruan <ruanjinjie@huawei.com> wrote:
>> sizeof(unsigned long) * 8 is the number of bits in an unsigned long
>> variable, replace it with BITS_PER_LONG macro to make it simpler.
>>
>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>> ---
>> kernel/printk/printk_ringbuffer.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/printk/printk_ringbuffer.h b/kernel/printk/printk_ringbuffer.h
>> index bd2a892deac1..7433fe477e08 100644
>> --- a/kernel/printk/printk_ringbuffer.h
>> +++ b/kernel/printk/printk_ringbuffer.h
>> @@ -122,7 +122,7 @@ enum desc_state {
>>
>> #define _DATA_SIZE(sz_bits) (1UL << (sz_bits))
>> #define _DESCS_COUNT(ct_bits) (1U << (ct_bits))
>> -#define DESC_SV_BITS (sizeof(unsigned long) * 8)
>> +#define DESC_SV_BITS BITS_PER_LONG
>
> We should also add:
>
> #include <linux/bits.h>
maybe #include <asm/bitsperlong.h> ?
>
> John Ogness
next prev parent reply other threads:[~2024-09-03 3:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 11:09 Jinjie Ruan
2024-09-02 12:07 ` John Ogness
2024-09-03 3:39 ` Jinjie Ruan [this message]
2024-09-03 3:53 Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e333684b-6833-fb62-2c6e-480f14333f8a@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®