From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4EF5C04FDF for ; Tue, 1 Aug 2023 14:02:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233079AbjHAOCO (ORCPT ); Tue, 1 Aug 2023 10:02:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231761AbjHAOCK (ORCPT ); Tue, 1 Aug 2023 10:02:10 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9F0FDC for ; Tue, 1 Aug 2023 07:02:05 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-31759e6a4a1so5094515f8f.3 for ; Tue, 01 Aug 2023 07:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690898524; x=1691503324; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BrksOpqUjAUEy32MmJaMJMaflmISBOfcCLnD5EwZNQs=; b=N9gHHLPjM6IBcosZN6lsCZQB0PC3Qg+0I5sgBo8lc354YLYXjn/OVVOLLNL+ftOW9F hQHRgh2W5rn/4ogvkrA9hwv/XUB+d2QjtnktFa+CKBEoxk8aBTPqLplBs+gXVZdR2jSJ teJPPZSAr2RjGsvaO6bdNfrAbkGxRiP3ciCXFObJlgW30pAK9395ra5kWOIg6xNZg9aw polBTKn6lv/Z0XIY/MgPM7z0SVq0HjiBJfngNPV+38Y7WJZmkb5lsTz3hJs945zkb7Z9 ITrbGATJa5wJJ3eDiJ2fTnpwCEwCmzMzdwHYKojmlrQLQVAr09HXoBoe29+6EDJHF+hz fACg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690898524; x=1691503324; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BrksOpqUjAUEy32MmJaMJMaflmISBOfcCLnD5EwZNQs=; b=VQYi4bJo7vtozqh2f9KOTlo0B6puOAn+RtEoCJaP0/SyhF2wrhKKf2/aO7lTwPFcEq gQv0beb373ymq5uPPXmnyGfAZTiEEslvnHwdn6h/+yg5QwOf3mLp43NBg7jpjh5vY5g6 SJOGBz1pkMTTEpByRMaU2SLt0l/Z8SAJbWbFkZuTiXahWhDRPzfphgY884o7Kj69ix4o 2IBjU8Ck+3qubnWytDejboAgIUKhelOu2jR9JI24HYBeBelpbtFgwlpks0UFj90I1EZ8 RwR2WkFElZ35wxmrmFYq6w+PnescqGjE0gwPVXM82/1WYFLTsy/jXJGAk4A60YfpZNIh S8pA== X-Gm-Message-State: ABy/qLbMh2bUytztUu4DdNRocOIJ2ehkpnjlQE13d/Und2iPE5FmW4Tj ILxS2ELmTCLGhgmDLpOJApHf+w== X-Google-Smtp-Source: APBJJlFGUJ6jKzWwPl5BWHR+yLvQlr2LJvZNj0hJ5Ewi60F1aSJcHQJyjja2O/DLLARvHjfEwo9ahA== X-Received: by 2002:adf:f5c2:0:b0:317:7068:4997 with SMTP id k2-20020adff5c2000000b0031770684997mr2414146wrp.60.1690898524261; Tue, 01 Aug 2023 07:02:04 -0700 (PDT) Received: from [192.168.69.115] ([176.176.174.59]) by smtp.gmail.com with ESMTPSA id f3-20020a5d50c3000000b00317909f9985sm11851806wrt.113.2023.08.01.07.02.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 07:02:03 -0700 (PDT) Message-ID: Date: Tue, 1 Aug 2023 16:02:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 09/12] KVM: x86/mmu: Replace MMU_DEBUG with proper KVM_PROVE_MMU Kconfig Content-Language: en-US To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Mingwei Zhang , David Matlack , Jim Mattson References: <20230729004722.1056172-1-seanjc@google.com> <20230729004722.1056172-10-seanjc@google.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230729004722.1056172-10-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/7/23 02:47, Sean Christopherson wrote: > Replace MMU_DEBUG, which requires manually modifying KVM to enable the > macro, with a proper Kconfig, KVM_PROVE_MMU. Now that pgprintk() and > rmap_printk() are gone, i.e. the macro guards only KVM_MMU_WARN_ON() and > won't flood the kernel logs, enabling the option for debug kernels is both > desirable and feasible. > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/Kconfig | 13 +++++++++++++ > arch/x86/kvm/mmu/mmu.c | 2 +- > arch/x86/kvm/mmu/mmu_internal.h | 4 +--- > 3 files changed, 15 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé