From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB56C3CBE7D for ; Tue, 26 May 2026 07:39:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779781178; cv=none; b=UKJ5WgeUPvb5skLr1JVXEjtFYf7Jr7tuodTffQeiEXb9HQvjnFB9bkRJPdmGrjXsHMFhPP8PNBEhwRb7pOulvGtuqnho2+nUGpmjzvd1OSV0epu85CxWeFEB6lVuKKxjZvnCRp6jII4H7VOqY7nBpNtuxzAQgtZOybX+QR8oG5c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779781178; c=relaxed/simple; bh=QROzjesojsza6o6DWliDyVXRJb1pE7GEdq3E60S7bsY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tACrIbQUqsnOLUHzJPxcIygm4SNNzTAYGsZyIpBsoiClTbMHiTkHabHqVykLAcDARXDI8wu0Yp7qLP7aHlzZLRvO2yuY5Zas/8BzG5PduvSvItoDuYnaDmAX7+t+nd9JEF4uo3mVf0y1txkI/n8evNeoP+tmQPwxHfnxF5qXKx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jS8/PSjE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jBECVF4P; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jS8/PSjE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jBECVF4P" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64Q5D6lB1802411 for ; Tue, 26 May 2026 07:39:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4jIGEP+z60S2yqQzDYqC9TS8A9yx2NRGZ+os1M5/9i8=; b=jS8/PSjE4Rp+Up6r vD1iIuYTubxtazNDwSGTnbqn3xAOoGu5A0Zmo1XrldHvCOJfdiKqIEYGWjgasV7P 7q7wuvyUB2co8lZceHNHhQBXJ0b5hxsjOvOG0YlcIvE2v8kIGf3KkP/eqrpc3M14 8ykWAyPcQeoyfS8L95KQiC/jxeoxYLDqNxBsOUYRqv/DE8RQhd25J6YnyiuKL1Jl xUtOEtTY1CQPbkq/jmRZKuEudA1iUBH2wrF3FkC9MZ095sACyZoddpf6ZJ1H0XS/ Ypu6w9JI1OaV7f4u87q0gaPMVaMDMeWzLUX9HlJJ0YTSHLMeJZLhM+zoafOWYHIB y5YlXg== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eckyqkjwa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 26 May 2026 07:39:35 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c829366cf25so13532149a12.0 for ; Tue, 26 May 2026 00:39:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779781175; x=1780385975; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4jIGEP+z60S2yqQzDYqC9TS8A9yx2NRGZ+os1M5/9i8=; b=jBECVF4PoXk1X1kqSS3OPfgsBaKLes27/21aCXBAiuq88NzoO2J6ZZC1WLtOU46wcr 34bxcJzb45IdUK96mvgBxMaAwvzAyyjc1LqnvqICnN2QgzjBvLXbT4sZKETopflCKKxs /qIfQkmMcI+17/81VWpO72nM/v//btGsOnAP+b8zgl7do98VNrDGmSZ7QZ0hxjd9WmX7 8EbbuIwECqyg8/8kE0cYd3zehq9hUJtRffVDpIHD3VObrZ8KXjflDBt0cScFrHOj2iUX KdE2c1TuR1/BUakZq2yjKOm7w1AoaS8ffGcdsn6D8imzD42YDrrp+fp23wqIB8Hc73cg uyRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779781175; x=1780385975; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4jIGEP+z60S2yqQzDYqC9TS8A9yx2NRGZ+os1M5/9i8=; b=mcWoliG61HK7iKLFFehUMaepWEBMVOQKXUUjKOYZvVY9V7G9WOeu3xSLPPhG69h9cI eQEIfHLQlwbdu+sV2eq6FmJAUeUxWBH6OciUw4w7RlhwSMO6SuKJBtLlEtDosYPqvOh5 jwSBpr1q5OJNCR9q2HgQFW/0sFyMvNy5n2fwqIYQ0Ik4uqFgRwenzOua2yyl+1+/SXHB 9jIFgyPLXoBAI90tGYQusDaHF8LrDRG0/jQfKSHHmlnN6ut3vzVN7SWBFi28Yz4uA79R vb/WdksZ8ywX9m0ExLraZ7wEwaLzSEmdfeNLZ/t1fCqoCZ0jcPLW0keB4C7f+hG+OBjg OcFQ== X-Forwarded-Encrypted: i=1; AFNElJ9YNcjn5QTVeCRGBj+EkOml3kpIsqbcv3xXcLq11bGrJ9kJIVlU1IXGdap8RSMMhfMlx6A72dYLMZLIzpw=@vger.kernel.org X-Gm-Message-State: AOJu0YzArMWfL+/wn6kIM/6QMk+8sLghMKGGykTr5kp7xDLn4OsA3Af4 eXTtNq7KfWfLspUk9YB/EREegmt23mfVvtnvFFwdKOlFrlezeSfgLwT8hBMTHshXKABNzttbDAJ qkAaWP93FBU4qFlrnfwCqUfe5cCWouPCVwC6GqVpXR8nyv4AHt8jRBcp17bBd7rqmsGw= X-Gm-Gg: Acq92OEMP6bybhOLMqC0LRFB4o30KLWbuIaqxmKvw4HmiMXd0w13LrHuKRb06pGHIED x/NXxCdGsL527QiX+64QNfRWW5Gugzn2AQKFjuJBkQBrBxLYtsEJ+lBrFxHSTsTTmdQhSkvblcQ KVkifYAbK/xUs/qMbaKkES3Hw9hWACkCdWe9qyxBqIjVKcic54NJFMDk4hLUlcdDwqyStAY7ngQ lAUDR9+mZROq+XvLPNsaNpyaEX2nQbb/e9UK+JHvsM9dc9RyuaxC+kTH9x7jFM23oXLX1g094aA Wv1X9hiNM7uxnKjEZnsRUa6q8ZvcfsgrqCWZpEVxk29CzOmxh4ryI0dBaOljh3JyoDIeiOXG27S tAP5RI6FrOHgByD0Gzh+p8IbPO0AN2UvNv5Xf6T6+i9bP70vlfto5AF6a5mU= X-Received: by 2002:a05:6a20:c90b:b0:3b3:216b:2743 with SMTP id adf61e73a8af0-3b328c4d6d0mr17344486637.4.1779781174719; Tue, 26 May 2026 00:39:34 -0700 (PDT) X-Received: by 2002:a05:6a20:c90b:b0:3b3:216b:2743 with SMTP id adf61e73a8af0-3b328c4d6d0mr17344438637.4.1779781174206; Tue, 26 May 2026 00:39:34 -0700 (PDT) Received: from [10.151.36.45] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c852056d767sm9446299a12.25.2026.05.26.00.39.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 00:39:33 -0700 (PDT) Message-ID: Date: Tue, 26 May 2026 13:09:29 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: regulator: mps,mp8899: Add binding for MP8899 PMIC To: Krzysztof Kozlowski Cc: Saravanan Sekar , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20260519-mp8899-regulator-driver-v1-0-30d14421b7f1@oss.qualcomm.com> <20260519-mp8899-regulator-driver-v1-1-30d14421b7f1@oss.qualcomm.com> <20260520-passionate-handsome-dogfish-9fc65b@quoll> Content-Language: en-US From: Vignesh Viswanathan In-Reply-To: <20260520-passionate-handsome-dogfish-9fc65b@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=RMyD2Yi+ c=1 sm=1 tr=0 ts=6a154e37 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=gEfo2CItAAAA:8 a=EUspDBNiAAAA:8 a=Ov9h6TAEAQTuY_HzltgA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-ORIG-GUID: pbZveklnjgvqS1p_wJWSvq0-3wChbW8d X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI2MDA2NCBTYWx0ZWRfX7+x3X6s7awG2 3NU116a5QTrw77uPvbvYCuJ80vzHUYuXdM6pS/Nzt1fJiFj6J3tujEQTI9S3OEmYiWwev5672iv 08EDBKew7SOLiL2BrwVyIw6ibvOHFFS41kZJ7ViU8ugBzHesW2lUZgPBQcAydNJ62fku8ucM3YO B/bypgYOcGQakVBN0iOOmOgAxRTYgMZT9IrVB4PMdEXlAIJi0r03PDk4oJTtIsZRVU2ZKgSAd++ OTc9XUj31stM8mi5pjlUI0s8DjftKZpeNyuGirzqV3tHNRkTQe5AvMl9c4iO1Tg7XhIICreLIob sP5B62uiRjiY8XHMAKMz+k62K5MZM6uJevilY9lYcmOU0rlfBlNsQ2aAkoBQukPil1NpDQsUZpw FO91o1jCzpWVK7Yk8waIehHsKO5dvZNxIFicjk+Ojb7io+aS0KpIoLNdXy1XnOR1Wzd4JBScQ1N Yv7yfR/WBhUjECNncKg== X-Proofpoint-GUID: pbZveklnjgvqS1p_wJWSvq0-3wChbW8d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-26_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605260064 On 5/20/2026 3:57 PM, Krzysztof Kozlowski wrote: > On Tue, May 19, 2026 at 11:51:05PM +0530, Vignesh Viswanathan wrote: >> Add devicetree binding documentation for the Monolithic Power Systems >> MP8899 PMIC, which provides four synchronous buck converters controlled >> over I2C. > > Please use subject prefixes matching the subsystem. You can get them for > example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory > your patch is touching. For bindings, the preferred subjects are > explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > >> >> Signed-off-by: Vignesh Viswanathan >> --- >> .../devicetree/bindings/regulator/mps,mp8899.yaml | 66 ++++++++++++++++++++++ >> 1 file changed, 66 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/regulator/mps,mp8899.yaml b/Documentation/devicetree/bindings/regulator/mps,mp8899.yaml >> new file mode 100644 >> index 000000000000..3225c92db2c8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/regulator/mps,mp8899.yaml >> @@ -0,0 +1,66 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/regulator/mps,mp8899.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Monolithic Power System MP8899 PMIC >> + >> +maintainers: >> + - Vignesh Viswanathan >> + >> +properties: >> + $nodename: >> + pattern: "^pmic@[0-9a-f]{1,2}$" > > Drop nodename. Ack. > >> + compatible: >> + enum: >> + - mps,mp8899 >> + >> + reg: >> + maxItems: 1 >> + >> + regulators: >> + type: object >> + >> + description: | > > Do not need '|' unless you need to preserve formatting. Ack. > >> + list of regulators provided by this controller, must be named >> + after their hardware counterparts BUCK[1-4] > > Drop description. Ack. > >> + >> + patternProperties: >> + "^buck[1-4]$": >> + type: object >> + $ref: regulator.yaml# >> + > > Droip blank line Ack. > >> + unevaluatedProperties: false >> + >> + additionalProperties: false > > Put this additionalProps after type. Ack. Thanks, Vignesh > >> + >> +required: >> + - compatible >> + - reg >> + - regulators > > Best regards, > Krzysztof >