mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jann Horn" <jannh@google.com>,
	"Andrew Morton" <akpm@linux-foundation.org>
Cc: "Masahiro Yamada" <masahiroy@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Zhen Lei" <thunder.leizhen@huawei.com>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	"Ard Biesheuvel" <ardb@kernel.org>
Subject: Re: [PATCH 1/2] kallsyms: get rid of code for absolute kallsyms
Date: Wed, 21 Feb 2024 22:18:47 +0100	[thread overview]
Message-ID: <e33a59f7-cf0e-4b63-b994-752d1e77652a@app.fastmail.com> (raw)
In-Reply-To: <20240221202655.2423854-1-jannh@google.com>

On Wed, Feb 21, 2024, at 21:26, Jann Horn wrote:
> To compile code for absolute kallsyms, you had to turn off
> KALLSYMS_BASE_RELATIVE. I think based on the way it was declared in
> Kconfig (without a string after "bool"), it wasn't even possible to
> select it.
>
> Get rid of this config option, as preparation for some kallsyms
> optimizations that would otherwise be infeasible.
>
> Signed-off-by: Jann Horn <jannh@google.com>

Nice catch!

The code was needed until cf8e8658100d ("arch: Remove
Itanium (IA-64) architecture"), and we missed that this
allowed the cleanup you now did.

Acked-by: Arnd Bergmann <arnd@arndb.de>

     Arnd

  parent reply	other threads:[~2024-02-21 21:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21 20:26 Jann Horn
2024-02-21 20:26 ` [PATCH 2/2] kallsyms: build faster by using .incbin Jann Horn
2024-02-21 20:29   ` Jann Horn
2024-02-22  4:06   ` Masahiro Yamada
2024-02-22  8:20     ` Arnd Bergmann
2024-02-22 11:20     ` Jann Horn
2024-02-22 14:20       ` Jann Horn
2024-02-23  4:26         ` Masahiro Yamada
2024-02-21 21:18 ` Arnd Bergmann [this message]
2024-02-23 12:33 ` [PATCH 1/2] kallsyms: get rid of code for absolute kallsyms Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e33a59f7-cf0e-4b63-b994-752d1e77652a@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=ardb@kernel.org \
    --cc=jannh@google.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=ojeda@kernel.org \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®