From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA4DC04A95 for ; Wed, 28 Sep 2022 09:33:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231976AbiI1JdB (ORCPT ); Wed, 28 Sep 2022 05:33:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233859AbiI1Jcl (ORCPT ); Wed, 28 Sep 2022 05:32:41 -0400 Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23826DF3B2 for ; Wed, 28 Sep 2022 02:32:35 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 4AE84580557; Wed, 28 Sep 2022 05:32:32 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Wed, 28 Sep 2022 05:32:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664357552; x= 1664361152; bh=qzh7AjvEfcvhQkxA/UL1+bOv++GlorS+C7InU5cHRYU=; b=e B8BGzXv0nkCdkoUNnYypgS+VcPJrxJZlDD69TK6oA40d+lqkDDeVzzkvSj27rucX YK/O4BZEyHHCvnWTvdx29AklODN29AriSRv4KdP1NTV6TypIx5viX1LPiVS3Tljj ZFVhTQhzUyYqesGf8QtYNXw77ddh/XEqfZzRjAofqbf5C7t8oVfGm7wZfmNuvKBu ygPkoajcNWLCO76QOqHzCxBEZ8uDFwT/Dx98wtsi/YSY7PfqdotG4ErfJJDTY5a5 GNZT5kbOiDdUdGudGNA/0C7akZ3U6JpvRIKirOx1mgSSERKFJFFd9jwZ9FbGxKcE i9gUOz3B3mQiDdUybxL+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664357552; x= 1664361152; bh=qzh7AjvEfcvhQkxA/UL1+bOv++GlorS+C7InU5cHRYU=; b=h a1TYICxmBm0bfTbFtC7hs5EgZXCiMLAuMTgdwFRCbEpfDXGUEuM90b6rruOXB4wk QNbe5lf+uX0CDQmHjEL7mca+cCQZhIABg+R0JFmza0hu9MSI5/U/Riz4j29BJJtN Mep9d6r4lemXljn9mB+0VvS5Gd0fawz/V8XyWbIOADcPmmnHny+8LT/ikwRn9A18 ucGV/ZWGNI8jWu0+jdILSH5b7gIbWzeVJ3UbleCvKROy0lMHkVoxIN5ajSVt1g6t kDM7STJtct4sEsSoqZoqGi0O+J0Q8aVK1EyjCYiFQIVTWG3OSsE5QykSLZ4bHuVe rpws53yeZ1ZZAlNFkrMwQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegkedgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeegfeejhedvledvffeijeeijeeivddvhfeliedvleevheejleetgedukedt gfejveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 8646CB60086; Wed, 28 Sep 2022 05:32:31 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-968-g04df58079d-fm-20220921.001-g04df5807 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20220928064934.70867-1-renzhijie2@huawei.com> Date: Wed, 28 Sep 2022 11:32:11 +0200 From: "Arnd Bergmann" To: "Sebastian Andrzej Siewior" , "Lukas Bulwahn" Cc: "Ren Zhijie" , "Andrew Morton" , "Nick Desaulniers" , "Nathan Chancellor" , "Vlastimil Babka" , "Masahiro Yamada" , seanjc@google.com, "Johannes Weiner" , ojeda@kernel.org, "Masami Hiramatsu" , "Dmitry Torokhov" , atomlin@redhat.com, ddiss@suse.de, "Christophe Leroy" , linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] init/Kconfig: fix unmet direct dependencies Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 28, 2022, at 11:14 AM, Sebastian Andrzej Siewior wrote: > On 2022-09-28 09:20:42 [+0200], Lukas Bulwahn wrote: >> > Couldn't this become a depends? >> It could also be a depends (to resolve the warning). > =E2=80=A6 >> It is just the question whether: >>=20 >> When PROC_FS is not set, should the CHECKPOINT_RESTORE still be >> visible as a config option to add (and then automatically add >> PROC_FS)? Then select is right here. > > then CHECKPOINT_RESTORE is the only option selecting PROC_FS while > everyone else depends on it _or_ avoids using it in the absence of > PROC_FS. Right, we should not mix 'select' and 'depends on' for the same symbol, as that leads to circular dependencies and general confusion. If there is no way to use CHECKPOINT_RESTORE without procfs, then the symbol should just not be visible (it will still show up with the dependency when one searches in menuconfig). Force-enabling a major subsystem like procfs from another symbol is not a good solution. Arnd