From: Vadym Tytan <titanv3585@gmail.com>
To: Terry Junge <linuxhid@cosmicgizmosystems.com>,
kernel test robot <lkp@intel.com>,
Roderick Colenbrander <roderick.colenbrander@sony.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH] HID: playstation: DS4: Add BT poll interval adjustment
Date: Mon, 30 Jun 2025 16:59:26 +0200 [thread overview]
Message-ID: <e33f4cec-dec5-41ae-a1dd-aa6953604526@gmail.com> (raw)
In-Reply-To: <cce2d94e-8798-489f-8c9f-68f021bb21a7@cosmicgizmosystems.com>
> Should it be .attr = { .name = "dualshock4_bt_poll_interval", .mode = 0644 }, ?
>
> Or did you not expand the macro fully on purpose?
>
> Thanks,
> Terry
Here's my own quote
> P.S. Macro was expanded and variable name was changed from `dev_attr_bt_poll_interval` to `dev_attr_dualshock4_bt_poll_interval` because this attribute only applies to DualShock4
So, yes, i expanded it like that on purpose, as it applies only to DS4,
and while being attribute, it applies only per device, so no collision
is possible.
You're welcome
Vadym
next prev parent reply other threads:[~2025-06-30 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250508210148.799578-1-titanv3585@gmail.com>
2025-05-08 21:41 ` Vadym Tytan
2025-05-09 22:06 ` kernel test robot
2025-05-13 8:44 ` Vadym Tytan
2025-06-30 3:41 ` Terry Junge
2025-06-30 14:59 ` Vadym Tytan [this message]
2025-06-08 18:08 ` Roderick Colenbrander
2025-06-09 12:25 ` Vadym Tytan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e33f4cec-dec5-41ae-a1dd-aa6953604526@gmail.com \
--to=titanv3585@gmail.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxhid@cosmicgizmosystems.com \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=roderick.colenbrander@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®