From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C7B118DF73 for ; Wed, 5 Mar 2025 20:53:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741208019; cv=none; b=t+X95PJGvrAnnwietWJCyXzbH2jvyQIMnv2JC2+NfAzyP59ql/4UrNH2J8gEmVurww/CDZ5JqQt58DoEOmqdlEJAOwJ3mS9GJTw2W/sSgaLsWv/ueWT29++5R89PGwGo3L7lUCaAxjwCaGD8z5CiebrPFtcyaCbmIeFQ0TTi3bs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741208019; c=relaxed/simple; bh=SEymZq2c8yzGiUuhr88MmZaFWv8Hs1TapCjDAUpBm3A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IegId5XW0rRx3qUiDdoRmK/h5tPE2YrsYU/Ju0HV8wXSEwxTFKcH0i49GaP5ub1j8FqUg2MZ0YIzgNzdplaIXmY7eUmvjjLL/1kVZmVzFEgm8wmRvP5pWy93sb60c+UR9RN5NBbxLd16JyXg9vTXdMfFLmpY9hiq/sdrSXKaS2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gWgYHvVg; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gWgYHvVg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741208016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JcyydLVKVQXWYYx+0XQnTj1NtApoU7gF9P0L7UfC6ok=; b=gWgYHvVgpkfFzwRzwVil7i3S6dvEmwQJb+56XRNF2zCuVDaTMzMdws4OzWn0R6fHVbisw3 HlAu0s6yBdCb+ylonGaYieJGHnQvBXGDnQV/dgRQp8/haqxsb3mFL6GobtnR9wnLMQ4Ops hA+uOFmRUgPLDMQpgfoe1aKB7RJkvtY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-YRsbCi0aMbSqnC18QLDqXA-1; Wed, 05 Mar 2025 15:53:24 -0500 X-MC-Unique: YRsbCi0aMbSqnC18QLDqXA-1 X-Mimecast-MFC-AGG-ID: YRsbCi0aMbSqnC18QLDqXA_1741208004 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-391079c9798so1875652f8f.3 for ; Wed, 05 Mar 2025 12:53:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741208003; x=1741812803; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JcyydLVKVQXWYYx+0XQnTj1NtApoU7gF9P0L7UfC6ok=; b=Pl7MXYO1DfadAs1DbxvRQ6Aaj7QOvbpAcAbe3B+jgisbcDgrRs6ts43o0y6GcPeZiq uyBmgNSbsrbPG6+pYNOpOvRiu9+CX0vZnJbFKCCjdBMDA2jywasaRqrDrpxLEAQNBxAy cof5XInTxvFqTjFpjxEZXgiOHxNhJ673/oEMKPLQS9/ZOwC+UlujtofnuznOGUpo8IB9 XfGFiweDyFQpPjbQ7mGfD5Q26iZdTy3xOWmd+nqkKxNsp11iH+9yTSDbhhDJ2VDXx/U8 7Sz7y2WQsglB/ReTquUNhnoQtbqZBJuuoK2agvjpl5IL2uH9b6i563DSAvHp1pywq9Ck teJA== X-Forwarded-Encrypted: i=1; AJvYcCUNEUzqhrLNyTzbsCDT4fWr4Pt2bmTDWCGDJmpZ3Og72AFJsDeDw0myEvSeEg1lnKWp+TZm0Z4PDhPVZkc=@vger.kernel.org X-Gm-Message-State: AOJu0YyVrmw6evqhnPcKdbPqOwTgnZXRwkLhWlEn2anhhQIO+XG/gRwQ 3Bn+DlHCuz2yE8vLn9X0ss4Lh/4rfB4CyGpdk7vD/MEYruGvi/dmIDHGqZp6AYeWW3X0ncCEt8G 92z9NCgyb0EqCwlJwHRBj2AZGQoc92KMQxs8Amp1mrZZ4tNQdB3elJuxERgKnYQ== X-Gm-Gg: ASbGncuFJkxVQoDNkeqLdqZmFHZOB3ix4jx1MR4vbo052EFvoPreSEQ8EkFwiyL0Xo1 XBIEyoSYha3tKqdSfyBM7MGHb2luJ14mJOtH8hbixx/YISovhczz2bHfzJSClGOBcManM525262 CECfMyzWLCspte/Kdp+4aln4Mea3BrhHJ/uTgEUBHk18W10nY1/lU5Gc/KcvhiDVMCAJtVZVXSM skXjhRdmjXt01szvloM0abqvqhbBXfK24pj/Tx7ozH5a0ZU5tEUfS0wAHZmxpHgcTqlYHqfpxVM DnwOg0eMK3cE7zqlfS4kcN8JqaTotb/rWkUlGZ1WZq7/Q8W+Yx7Ar3kTM5D4onJDyr55WyMtDN/ cMlLIMXC3FwzEJsSj8MMGL/c6QCDTtYI3pgR8NMePdAk= X-Received: by 2002:a5d:64e2:0:b0:38d:de45:bf98 with SMTP id ffacd0b85a97d-3911f726560mr4098332f8f.8.1741208003674; Wed, 05 Mar 2025 12:53:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IFfukgVDlhzT+kgCOXAaihcOAsjJMWHKbsPU3wieu5zGSUxuy02J4K/cvTgo7N/nkjN8+amrw== X-Received: by 2002:a5d:64e2:0:b0:38d:de45:bf98 with SMTP id ffacd0b85a97d-3911f726560mr4098299f8f.8.1741208003197; Wed, 05 Mar 2025 12:53:23 -0800 (PST) Received: from ?IPV6:2003:cb:c739:5b00:84f2:50f3:bdc8:d500? (p200300cbc7395b0084f250f3bdc8d500.dip0.t-ipconnect.de. [2003:cb:c739:5b00:84f2:50f3:bdc8:d500]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e4844892sm22239947f8f.64.2025.03.05.12.53.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Mar 2025 12:53:22 -0800 (PST) Message-ID: Date: Wed, 5 Mar 2025 21:53:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next v1 0/3] kernel/events/uprobes: uprobe_write_opcode() rewrite To: Andrii Nakryiko Cc: Oleg Nesterov , Andrii Nakryiko , Jiri Olsa , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Morton , Matthew Wilcox , Russell King , Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Ian Rogers , Adrian Hunter , "Liang, Kan" , Tong Tiangen References: <20250304154846.1937958-1-david@redhat.com> <20250305152055.GB28112@redhat.com> <62f93f79-a8d4-44a5-b276-3ac5af4ab25c@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05.03.25 20:58, Andrii Nakryiko wrote: > On Wed, Mar 5, 2025 at 11:47 AM David Hildenbrand wrote: >> >> On 05.03.25 20:43, Andrii Nakryiko wrote: >>> On Wed, Mar 5, 2025 at 7:22 AM Oleg Nesterov wrote: >>>> >>>> On 03/04, David Hildenbrand wrote: >>>>> >>>>> Currently, uprobe_write_opcode() implements COW-breaking manually, which is >>>>> really far from ideal. >>>> >>>> To say at least ;) >>>> >>>> David, thanks for doing this. I'll try to read 3/3 tomorrow, but I don't >>>> think I can really help. Let me repeat, this code was written many years >>>> ago, I forgot everything, and today my understanding of mm/ is very poor. >>>> But I'll try anyway. >>>> >>>>> Are there any uprobe tests / benchmarks that are worth running? >>>> >>>> All I know about uprobe tests is that bpf people run a lot of tests which >>>> use uprobes. >>>> >>>> Andrii, Jiri, what you advise? >>>> >>> >>> We do have a bunch of tests within BPF selftests: >>> >>> cd tools/testing/selftest/bpf && make -j$(nproc) && sudo ./test_progs -t uprobe >> >> I stumbled over them, but was so far not successful in building them in >> my test VM (did not try too hard, though). Will try harder now that I >> know that it actually tests uprobe properly :) > > If you have decently recent Clang and pahole, then just make sure you > have kernel built before you build selftests. So above instructions > are more like: > > 1. cd > 2. cat tools/testing/selftests/bpf/{config, config.} >> .config ^ that did the trick > 3. make -j$(nproc) # build kernel with that adjusted config > 4. cd tools/testing/selftests/bpf > 5. make -j$(nproc) # build BPF selftests > 6. sudo ./test_progs -t uprobe # run selftests with "uprobe" in their name #444 uprobe:OK #445 uprobe_autoattach:OK #446/1 uprobe_multi_test/skel_api:OK #446/2 uprobe_multi_test/attach_api_pattern:OK #446/3 uprobe_multi_test/attach_api_syms:OK #446/4 uprobe_multi_test/link_api:OK #446/5 uprobe_multi_test/bench_uprobe:OK #446/6 uprobe_multi_test/bench_usdt:OK #446/7 uprobe_multi_test/attach_api_fails:OK #446/8 uprobe_multi_test/attach_uprobe_fails:OK #446/9 uprobe_multi_test/consumers:OK #446/10 uprobe_multi_test/filter_fork:OK #446/11 uprobe_multi_test/filter_clone_vm:OK #446/12 uprobe_multi_test/session:OK #446/13 uprobe_multi_test/session_single:OK #446/14 uprobe_multi_test/session_cookie:OK #446/15 uprobe_multi_test/session_cookie_recursive:OK #446/16 uprobe_multi_test/uprobe_sesison_return_0:OK #446/17 uprobe_multi_test/uprobe_sesison_return_1:OK #446/18 uprobe_multi_test/uprobe_sesison_return_2:OK #446 uprobe_multi_test:OK #447/1 uprobe_syscall/uretprobe_regs_equal:OK #447/2 uprobe_syscall/uretprobe_regs_change:OK #447/3 uprobe_syscall/uretprobe_syscall_call:OK #447/4 uprobe_syscall/uretprobe_shadow_stack:SKIP #447 uprobe_syscall:OK (SKIP: 1/4) Summary: 4/21 PASSED, 1 SKIPPED, 0 FAILED Looks promising, thanks! -- Cheers, David / dhildenb