mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Zhu Lingshan <lingshan.zhu@intel.com>,
	mst@redhat.com, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: lulu@redhat.com, dan.daly@intel.com, cunming.liang@intel.com
Subject: Re: [PATCH V2 1/2] vdpa: Support config interrupt in vhost_vdpa
Date: Sun, 26 Apr 2020 15:03:29 +0800	[thread overview]
Message-ID: <e345cc85-aa9d-1173-8308-f0a301fca2b2@redhat.com> (raw)
In-Reply-To: <055fb826-895d-881b-719c-228d0cc9a7bf@redhat.com>


On 2020/4/26 下午2:58, Jason Wang wrote:
>>
>> diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
>> index 1813821..8663139 100644
>> --- a/drivers/vhost/vhost.h
>> +++ b/drivers/vhost/vhost.h
>> @@ -18,6 +18,8 @@
>>   typedef void (*vhost_work_fn_t)(struct vhost_work *work);
>>     #define VHOST_WORK_QUEUED 1
>> +#define VHOST_FILE_UNBIND -1
>
>
> I think it's better to document this in uapi. 


I meant e.g in vhost_vring_file, we had a comment of unbinding:

struct vhost_vring_file {
     unsigned int index;
     int fd; /* Pass -1 to unbind from file. */

};

Thanks


  reply	other threads:[~2020-04-26  7:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-26  6:09 [PATCH V2 0/2] Config interrupt support in VDPA and IFCVF Zhu Lingshan
2020-04-26  6:09 ` [PATCH V2 1/2] vdpa: Support config interrupt in vhost_vdpa Zhu Lingshan
2020-04-26  6:58   ` Jason Wang
2020-04-26  7:03     ` Jason Wang [this message]
     [not found]       ` <fb51aa36-9a58-fd50-a4fa-4cc887357367@linux.intel.com>
2020-04-26  7:38         ` Jason Wang
2020-04-26  6:09 ` [PATCH V2 2/2] vdpa: implement config interrupt in IFCVF Zhu Lingshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e345cc85-aa9d-1173-8308-f0a301fca2b2@redhat.com \
    --to=jasowang@redhat.com \
    --cc=cunming.liang@intel.com \
    --cc=dan.daly@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=lingshan.zhu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®