From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Song Liu <song@kernel.org>,
Nadav Amit <namit@vmware.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] x86/retpoline: Fix crash printing warning
Date: Wed, 26 Oct 2022 01:59:52 +0700 [thread overview]
Message-ID: <e3464bac-82cb-2180-74f5-448e70540190@gnuweeb.org> (raw)
In-Reply-To: <Y1gBoUZrRK5N/lCB@kili>
On 10/25/22 10:32 PM, Dan Carpenter wrote:
> The first argument of WARN() is a condition, so this will use "addr"
> as the format string and possibly crash.
>
> Fixes: 3b6c1747da48 ("x86/retpoline: Add SKL retthunk retpolines")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Hello x86 maintainers,
I found this patch in the tip tree with the following commit message:
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/core&id=98dcf58159365d753b54d07f85a89d61ee15e036
x86/retpoline: Fix crash printing warningx86/core
The first argument of WARN() is a condition, so this will use "addr"
as the format string and possibly crash.
Fixes: 3b6c1747da48 ("x86/retpoline: Add SKL retthunk retpolines")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Link: https://lkml.kernel.org/r/Y1gBoUZrRK5N/lCB@kili
When I visited that lkml link, it shows "message ID not found". The
problem seems to be coming from the tool used to pick up the patch.
That message ID contains a URL special char '/'. Thus it should be
URL-encoded like this:
https://lore.kernel.org/r/Y1gBoUZrRK5N%2FlCB%40kili
Anyway, lkml.kernel.org doesn't work for such a message ID, even with
URL-encoded message ID like this:
https://lkml.kernel.org/r/Y1gBoUZrRK5N%2FlCB%40kili (not found)
--
Ammar Faizi
next prev parent reply other threads:[~2022-10-25 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 15:32 Dan Carpenter
2022-10-25 18:59 ` Ammar Faizi [this message]
2022-10-25 19:25 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3464bac-82cb-2180-74f5-448e70540190@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=dan.carpenter@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®