mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: luojiaxing <luojiaxing@huawei.com>,
	jinpu.wang@cloud.ionos.com, jejb@linux.ibm.com,
	martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxarm@huawei.com
Subject: Re: [PATCH v1 1/2] scsi: pm8001: clean up for white space
Date: Wed, 7 Apr 2021 14:56:15 -0700	[thread overview]
Message-ID: <e3532ffe-f750-5c95-7f8f-aafc86b094ca@acm.org> (raw)
In-Reply-To: <3dd042b3-eb86-f0aa-5542-3f763f6830e0@huawei.com>

On 4/5/21 11:39 PM, luojiaxing wrote:
> 
> On 2021/4/3 0:01, Bart Van Assche wrote:
>> On 4/2/21 2:08 AM, Luo Jiaxing wrote:
>>>   #define AAP1_MEMMAP(r, c) \
>>> -    (*(u32 *)((u8*)pm8001_ha->memoryMap.region[AAP1].virt_ptr + (r) 
>>> * 32 \
>>> +    (*(u32 *)((u8 *)pm8001_ha->memoryMap.region[AAP1].virt_ptr + (r) 
>>> * 32 \
>>>       + (c)))
>> Since this macro is being modified, please convert it into an inline
>> function such that the type of the arguments can be verified by the
>> compiler.
> 
> Sure, but still keep the function name as AAP1_MEMMAP?

The coding style requires lower case names for functions so the function 
name probably should be converted to lower case.

Thanks,

Bart.

  reply	other threads:[~2021-04-07 21:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-02  9:08 [PATCH v1 0/2] scsi: pm8001: tiny clean up patches Luo Jiaxing
2021-04-02  9:08 ` [PATCH v1 1/2] scsi: pm8001: clean up for white space Luo Jiaxing
2021-04-02 16:01   ` Bart Van Assche
2021-04-06  6:39     ` luojiaxing
2021-04-07 21:56       ` Bart Van Assche [this message]
2021-04-08 12:18         ` luojiaxing
2021-04-02  9:08 ` [PATCH v1 2/2] scsi: pm8001: clean up for open brace Luo Jiaxing
2021-04-02 16:03   ` Bart Van Assche
2021-04-06  6:40     ` luojiaxing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3532ffe-f750-5c95-7f8f-aafc86b094ca@acm.org \
    --to=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=luojiaxing@huawei.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®