From: Joe Perches <joe@perches.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org
Subject: [PATCH 07/11] flow.h/flow_keys.h: Remove extern from function prototypes
Date: Fri, 20 Sep 2013 11:23:24 -0700 [thread overview]
Message-ID: <e353e88cf7202a9977a6caada9123dc57d968ee6.1379701322.git.joe@perches.com> (raw)
In-Reply-To: <597c1b62607f823af60dc4a99d59373dddfb7837.1379701322.git.joe@perches.com>
There are a mix of function prototypes with and without extern
in the kernel sources. Standardize on not using extern for
function prototypes.
Function prototypes don't need to be written with extern.
extern is assumed by the compiler. Its use is as unnecessary as
using auto to declare automatic/local variables in a block.
Signed-off-by: Joe Perches <joe@perches.com>
---
include/net/flow.h | 11 ++++++-----
include/net/flow_keys.h | 2 +-
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/include/net/flow.h b/include/net/flow.h
index 628e11b..65ce471 100644
--- a/include/net/flow.h
+++ b/include/net/flow.h
@@ -215,12 +215,13 @@ typedef struct flow_cache_object *(*flow_resolve_t)(
struct net *net, const struct flowi *key, u16 family,
u8 dir, struct flow_cache_object *oldobj, void *ctx);
-extern struct flow_cache_object *flow_cache_lookup(
- struct net *net, const struct flowi *key, u16 family,
- u8 dir, flow_resolve_t resolver, void *ctx);
+struct flow_cache_object *flow_cache_lookup(struct net *net,
+ const struct flowi *key, u16 family,
+ u8 dir, flow_resolve_t resolver,
+ void *ctx);
-extern void flow_cache_flush(void);
-extern void flow_cache_flush_deferred(void);
+void flow_cache_flush(void);
+void flow_cache_flush_deferred(void);
extern atomic_t flow_cache_genid;
#endif
diff --git a/include/net/flow_keys.h b/include/net/flow_keys.h
index bb8271d..ac2439d 100644
--- a/include/net/flow_keys.h
+++ b/include/net/flow_keys.h
@@ -13,5 +13,5 @@ struct flow_keys {
u8 ip_proto;
};
-extern bool skb_flow_dissect(const struct sk_buff *skb, struct flow_keys *flow);
+bool skb_flow_dissect(const struct sk_buff *skb, struct flow_keys *flow);
#endif
--
1.8.1.2.459.gbcd45b4.dirty
next prev parent reply other threads:[~2013-09-20 18:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 18:23 [PATCH 01/11] compat.h: " Joe Perches
2013-09-20 18:23 ` [PATCH 02/11] dcbevent.h: " Joe Perches
2013-09-20 18:23 ` [PATCH 03/11] decnet (dn*.h): " Joe Perches
2013-09-20 18:23 ` [PATCH 04/11] dst.h: " Joe Perches
2013-09-20 18:23 ` [PATCH 05/11] esp.h: " Joe Perches
2013-09-20 18:23 ` [PATCH 06/11] fib_rules.h: " Joe Perches
2013-09-20 18:23 ` Joe Perches [this message]
2013-09-20 18:23 ` [PATCH 08/11] garp.h: " Joe Perches
2013-09-20 18:23 ` [PATCH 09/11] gen_stats.h: " Joe Perches
2013-09-20 18:23 ` [PATCH 10/11] genetlink.h: " Joe Perches
2013-09-20 18:23 ` [PATCH 11/11] icmp.h: " Joe Perches
2013-09-20 18:49 ` [PATCH 01/11] compat.h: " David Miller
2013-09-20 18:53 ` Joe Perches
2013-09-20 18:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e353e88cf7202a9977a6caada9123dc57d968ee6.1379701322.git.joe@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®