mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bean Huo <huobean@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: beanhuo@micron.com
Subject: Re: [PATCH 0/2] use generic_file_buffered_read()
Date: Mon, 07 Sep 2020 13:37:11 +0200	[thread overview]
Message-ID: <e35560d7ecf257a87dce544fe3a4d58e2998465b.camel@gmail.com> (raw)
In-Reply-To: <e857400e-f6e8-9d84-804e-88f3c34edb50@kernel.dk>

On Fri, 2020-09-04 at 10:53 -0600, Jens Axboe wrote:
> > Bean Huo (2):
> >    block: use generic_file_buffered_read()
> >    fs: isofs: use generic_file_buffered_read()
> 
> The change is fine, but the title/commit message should reflect that
> this is just a comment change. The way it currently reads, it sounds
> like a functional change where something is switched over to using
> generic_file_buffered_read().
> 

Hi Jens
Indeed, it's easy to mistake this for a functional change, but it's
actually a comment change. I have corrected them in the new patch, you
can check now.

thanks,
Bean


      reply	other threads:[~2020-09-07 11:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04  9:13 Bean Huo
2020-09-04  9:13 ` [PATCH 1/2] block: " Bean Huo
2020-09-04  9:13 ` [PATCH 2/2] fs: isofs: " Bean Huo
2020-09-04 16:53 ` [PATCH 0/2] " Jens Axboe
2020-09-07 11:37   ` Bean Huo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e35560d7ecf257a87dce544fe3a4d58e2998465b.camel@gmail.com \
    --to=huobean@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=beanhuo@micron.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®