From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D210B3E0C6F for ; Mon, 18 May 2026 07:53:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779090826; cv=none; b=mzCKmfSBTuxZLIZ2J1LkZ4jziFKDvLeKE97NJ7KdvINmH3+L4ynpblJBr3a+9A7D8eSJprUFolzFSRKdueAE3YxrdwEVtV2uFCGK3GkuCeyM9TOnzvGU4/RdxOSL9pAYjWxMD+iO6QgaNIusi1nWxe+dXwwOWR3kgkkVJh1ybno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779090826; c=relaxed/simple; bh=B9gyGzCV1B54Pe8zE/IjJGy0FqlQ/bm+Wt6xaBcByfY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V0XwcbyrldhHgkWZgL1VgxsGgiQpfm5z2GfiYRa5LO2kRGbtjbxBGeTsu8TQRNkCJ3IzglJV8OUFyhwhHfxVl1QdYsy8WJkZeKsJfXL97GVkJJfyP6No5KXD0J+9ilXnS5eJgXoizIUWUFQOG+z0rzOt9QpV9+X1o+faoglem10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mbgbxFSR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dTngxWMj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mbgbxFSR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dTngxWMj" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64I7fZpg2188790 for ; Mon, 18 May 2026 07:53:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dXxtdNBAthLA/h80lp+57IJHfTZAirh3+QYdTFgQFE4=; b=mbgbxFSRDwBQdxNy 0+oxP5n4iF+DtH42d/MWqM7JoEXQSrCfwGQ/3s2THAU6/35ess9Ud4v6BHe1lOYO g5aiJasDhXLphcMoNxd5QHA9adm+EHEed8lIGBPDdl7K4BqYseVtlMV0oQlv/Cru LTYIOd7/8fvros62aRVAstKOzF21B1oLDF6d+k9SAcnZ1HEtDZAvVdKVr7BJJymp IWiqz+BPcAJTDOapXhY3G6BIPc41Ub3Y1ns0jrQOEmB43Hi9PNLSW6vvxklKRNC0 EQUll9rqsS/qT/n7knGd4JDTcqpwQlLulnlWeCUtIQbu4UDMSq9GblUxE7swk5ZI VONyDA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e7xkug1fr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 07:53:41 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50de6db1eabso7412801cf.0 for ; Mon, 18 May 2026 00:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779090821; x=1779695621; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dXxtdNBAthLA/h80lp+57IJHfTZAirh3+QYdTFgQFE4=; b=dTngxWMj9Es0h+/Z5/wmlUMxW/FzHY6+/a0uyMXQpNTx31UmXxeQe7jD5RbQyEcSM3 nbMAyg5fEZeNlk+OtGqe0BPDrmtZ1DcdSt82emgq+k41fOf8p4uXuzq0GlyAFl1pkIoL QGM9Wj6wMmmej70PVgfNNNfK6ARHNVcAcfr5SNbL05+SKhON9sjcPjf8Zyv+GN4gc7bD +5udVCExsZLwxzwc3JHFNKyfTPpM7RzFW7KUGfwIOf233zJjpO5c4alkXnTt5OfeWVzz PThx83IyKSIuGcWWb+N8+wNbkY8YQy9bJW/evQMVcVrk8G6GdX1bHVjIFySZQtIGQjTS vOiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779090821; x=1779695621; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dXxtdNBAthLA/h80lp+57IJHfTZAirh3+QYdTFgQFE4=; b=g4hijPnK019rVRRRim37Bkb0OGYiI+0TK6qkKGJPnIM6Sr2BcgV+eS17AIh7E7B40m LVpMXJU+08VIsVkvCwIEPhDpTewrFCWtiSI+aZn6FgyTUJNv6NsY/0Nx9E1oBaLaIMWR vkOK6SrgvJuilcBD4eafpmLcHpg3sitl6yYWw34FRzDA6oQ7t7RLF+FRlzDg19fe5qgt IVtcmP8iWUdfr63ukApD6o9X3YjKERnMCB9C0GAdfoEKjn/4fJZpmWrOu0sMdzLnPkUK vDAMsF9ishxNGtymETYz8ZpAaqcdScm8GhOI8EiajG9uH1am0UEze1xj6xZ5ujLJ1h8V QTog== X-Forwarded-Encrypted: i=1; AFNElJ8weImF9GGWnC53O2LR/lRXq1nENZbv1zm9pX88UMCr9dbFmLxLE0MhxumdBOcxpqO+pN9j+lJpg8zXT2o=@vger.kernel.org X-Gm-Message-State: AOJu0Yz88VJiIgDAV2Lb0ThdBQAnTOwcIepBO6wh5AADY3go3mvqGSX8 An2IaK92FrD6gfoPCD/3ZFdk0NzFOHH3IRh8um0KAeBn1nHrfFk4DumC+EPK5oRDBsPSR2IGpkV TUPJH5v+UFwfhxMAj9hGPtPGbBsq2QFObBrgMpFw4KH04VK5PrwN4jte4Zp3YSp6nxT8= X-Gm-Gg: Acq92OEiLJ7EWcDQDIvxLHPVjkzoRL5ltsaazfNK9ZnB2iaBJ2SeUmasC+bK9zCgwQ/ 3vN8kQ5U/bxLUQLW4uu2rZY1ftI810pHKnQ7/z6CljumArLUJ3y5M6hgC8vRMC9XGqzzYq0BYXg 3hLRimhD2Fx0mbeMkuINKBusnXLVtH2r5+lhX6YMvOb7iaLJ7/Hfm9Yv7uKdp+WhOLo9oab3eHV aKE+gSQ7r0+qlrN4Z1mofOQyL2UdMhvUNQbr/pk8kT01fVeAY+hdskReC/TJzShRnyntwYJjLzs 9PSy5zYiX+ba51TO/PkyGm4TlouA2BJnFvhVyLPxT+8aAOy7MrIx6JOwIxl4Fg5/6b9eHDM6GH0 dUcRd+IsTOKflWsPodnyjckqeuwqKlx76pBEjsraqN/uacxRs1Eo4DjeazOlvzXorS3JB2YQrXr drzGKQhadxE8lKyw== X-Received: by 2002:a05:622a:4d0c:b0:50f:b9a6:82ae with SMTP id d75a77b69052e-51659fadfe7mr113897981cf.2.1779090820560; Mon, 18 May 2026 00:53:40 -0700 (PDT) X-Received: by 2002:a05:622a:4d0c:b0:50f:b9a6:82ae with SMTP id d75a77b69052e-51659fadfe7mr113897711cf.2.1779090819967; Mon, 18 May 2026 00:53:39 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6831187d5f0sm4789600a12.28.2026.05.18.00.53.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 00:53:38 -0700 (PDT) Message-ID: Date: Mon, 18 May 2026 09:53:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: qcom: dts: qcm6490: Add JPEG encoder DT properties To: Atanas Filipov , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kapatrala Syed , Hariram Purushothaman , Bjorn Andersson , Konrad Dybcio , Gjorgji Rosikopulos , afilipov@quicinc.com Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260515-qcom-jpeg-v4l2-v1-0-f38c2e1b3555@oss.qualcomm.com> <20260515-qcom-jpeg-v4l2-v1-3-f38c2e1b3555@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260515-qcom-jpeg-v4l2-v1-3-f38c2e1b3555@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDA3NCBTYWx0ZWRfX7DTcZQ7IJZO3 5qKyWHbQoFIeEbmZJ51V32YfSxMWyfN1SWZoP7btID4XVxU3O3aIDh7FqzCnwrba0Kfr9vpo4nS j5koCdq87IyKgEHltvmH28PQTeaF5e8JF17nsyYBwu0TT6vGBegvuLSVpOt4THnQSki5dDsrpva rAdDQAufK+vN7bRKCnHJtdG9l9xPIjLML7P9KNwwbhk8/D9GRRmdkTODLHrSPntKNE7KcNe2/7H +27A0A80h2TtxdVQfAN54ZOqBnZLc+fvPJPEL2Yz7Jgs7HBVkV9Nx4JuyCcn86N1CNzQEN/eW0q l+V6FIBp4G8AOfhLpRH+R1njdJckLFpNrOyGDZL0YsFMGJW59W9g6xtiOR4dpqG0SL5I8lUPyMQ x0gcKRcXigbj83Ef6QTaRWV1CYrmkrAV8H1D8FSxreahvcYcw/NiYsPGJXX2PyDLEbBfqom2f42 7Ii7nd0Qn7NoRhxRlpg== X-Proofpoint-GUID: cFsWsAQCcr_6xWlD7DLDwBGbuAnWZqiO X-Proofpoint-ORIG-GUID: cFsWsAQCcr_6xWlD7DLDwBGbuAnWZqiO X-Authority-Analysis: v=2.4 cv=FsY1OWrq c=1 sm=1 tr=0 ts=6a0ac585 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=xYWKWClV66zwq8RDQgIA:9 a=S4w2FMICIi4s7N89:21 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_02,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180074 On 5/15/26 1:47 PM, Atanas Filipov wrote: > Add the required JPEG encoder definitions to the device tree. > > Signed-off-by: Atanas Filipov > --- > arch/arm64/boot/dts/qcom/kodiak.dtsi | 52 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi > index 6079e67ea829..dbfc6cc051f3 100644 > --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi > +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi > @@ -5198,6 +5198,58 @@ port@4 { > }; > }; > > + qcom_jpeg_enc: qcom,jpegenc@ac4e000 { > + cell-index = <0>; Will there ever be more than one instance of it? cell-index is generally discouraged [...] > + iommus = > + <&apps_smmu 0x20C0 0x20>, > + <&apps_smmu 0x20E0 0x20>; Please use lowercase hex > + > + interconnects = > + <&gem_noc MASTER_APPSS_PROC 0 > + &cnoc2 SLAVE_CAMERA_CFG 0>, > + <&mmss_noc MASTER_CAMNOC_HF 0 > + &mc_virt SLAVE_EBI1 0>, > + <&mmss_noc MASTER_CAMNOC_SF 0 > + &mc_virt SLAVE_EBI1 0>, > + <&mmss_noc MASTER_CAMNOC_ICP 0 > + &mc_virt SLAVE_EBI1 0>; Instead of zeros, use defines from include/dt-bindings/interconnect/qcom,icc.h Konrad