From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [RFC PATCH v3 0/2] rust: crates in other kernel directories
Date: Sun, 18 Feb 2024 13:11:47 -0300 [thread overview]
Message-ID: <e3562896-2d4f-42cd-be7f-6c7fb7fd08a1@gmail.com> (raw)
In-Reply-To: <CAK7LNAT4zKWn6+scn5wbaN2_x4wh4EYSuNxnaoQK1FfJK45MOw@mail.gmail.com>
On 11/13/23 11:13, Masahiro Yamada wrote:
> [...]
>
> I will not provide a line-by-line review.
>
>
> Just one thing I'd like to point out.
>
> You assume the library (drivers/usb/core/*)
> is built before its consumers (samples/rust/*).
>
> If Kbuild ends up with building lib consumers first,
> it will be a build error.
>
>
>
> Kbuild descends into multiple directories in parallel building.
>
> You cannot predict which directory is built first.
>
> [...]
Thinking with what you've said the same thing might apply to any Rust
written code that depends on crates under the `rust` dir. Adding
Make dependencies to object code made from `.rs` will be required if so,
assuming that Kbuild is intelligent enough to build the crates first.
next prev parent reply other threads:[~2024-02-18 16:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 21:11 Martin Rodriguez Reboredo
2023-11-04 21:11 ` [RFC PATCH v3 1/2] kbuild: Build Rust crates as libraries Martin Rodriguez Reboredo
2023-11-04 21:11 ` [RFC PATCH v3 2/2] samples: rust: Add USB sample bindings Martin Rodriguez Reboredo
2023-11-05 7:26 ` Greg Kroah-Hartman
2023-11-13 14:13 ` [RFC PATCH v3 0/2] rust: crates in other kernel directories Masahiro Yamada
2024-02-18 16:11 ` Martin Rodriguez Reboredo [this message]
2024-02-19 9:05 ` Masahiro Yamada
2024-03-15 13:44 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3562896-2d4f-42cd-be7f-6c7fb7fd08a1@gmail.com \
--to=yakoyoku@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®