From: Song Chen <chensong_2000@189.cn>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: johan@kernel.org, elder@kernel.org, thierry.reding@gmail.com,
u.kleine-koenig@pengutronix.de, lee.jones@linaro.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
elder@ieee.org
Subject: Re: [PATCH v4] staging: greybus: introduce pwm_ops::apply
Date: Wed, 16 Mar 2022 09:35:26 +0800 [thread overview]
Message-ID: <e3567bf5-242d-ecdc-2a51-22c4d7d6f356@189.cn> (raw)
In-Reply-To: <Yi9ZTdcZsdDjecC3@kroah.com>
在 2022/3/14 23:03, Greg KH 写道:
> On Wed, Mar 09, 2022 at 09:59:34AM +0800, Song Chen wrote:
>> Introduce newer .apply function in pwm_ops to
>> replace legacy operations,like enable, disable,
>> config and set_polarity.
>
> You can use the full 72 columns please.
will do.
>
>> This guarantees atomic changes of the pwm
>> controller configuration and also reduces the
>> size of the driver.
>
> The driver is bigger (more lines) with this change, so why do you say it
> is smaller?
ohh, yes, you are right. I copied from another commit with similar
function and didn't count lines carefully.
i will amend the commit message and submit a new one, many thanks.
>
> thanks,
>
> greg k-h
>
BR
Song
prev parent reply other threads:[~2022-03-16 1:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 1:59 Song Chen
2022-03-14 15:03 ` Greg KH
2022-03-16 1:35 ` Song Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3567bf5-242d-ecdc-2a51-22c4d7d6f356@189.cn \
--to=chensong_2000@189.cn \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®