From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754368AbdEDNdt (ORCPT <rfc822;w@1wt.eu>);
        Thu, 4 May 2017 09:33:49 -0400
Received: from mga02.intel.com ([134.134.136.20]:37973 "EHLO mga02.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751297AbdEDNdk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 4 May 2017 09:33:40 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,287,1491289200"; 
   d="scan'208";a="82460245"
Subject: Re: [PATCH] use get_random_long for the per-task stack canary
To: Daniel Micay <danielmicay@gmail.com>,
        Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@elte.hu>,
        kernel-hardening@lists.openwall.com,
        LKML <linux-kernel@vger.kernel.org>
References: <20170504133209.3053-1-danielmicay@gmail.com>
Cc: stable@vger.kernel.org
From: Arjan van de Ven <arjan@linux.intel.com>
Message-ID: <e358b217-7bae-07bb-4245-12d62513c733@linux.intel.com>
Date: Thu, 4 May 2017 06:33:15 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170504133209.3053-1-danielmicay@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/4/2017 6:32 AM, Daniel Micay wrote:
> The stack canary is an unsigned long and should be fully initialized to
> random data rather than only 32 bits of random data.

that makes sense to me... ack