From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C77D935C1B7 for ; Tue, 26 May 2026 05:54:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779774898; cv=none; b=GDV11BCXFjQUcxkOjAZRCLqAmunzS0ovkDY28DIU0MzBZ0k+oLns76WpT0CN0b6pQhFOfnbw/HR5nVWHJGxhgMUDbgTs9XB0gTWhbXDXshawytfXRbAfd/XKqNKzNQgKCi+0pFVHKdUKrAbMHbjA4ecMDHXEqlCoPm+Vba4mlDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779774898; c=relaxed/simple; bh=XV8WXEBQ+KA6ck7/dQgBHUtYvxXLzHdoZQRLWtMR3XE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=T/XypP0tBs0Kut62pC4QXYI4s/Y9BbtcgBK4dnkmAAcCvxrKrpF/9rgaaovESwutGTpMmIjBCs38HwMYmU5/futvcvbNInVm9WV3KBTbPx6pH8mrUyUUYLhf9/5lcc2VmMOQ+oqSfAfmjmSJLslh5hn9UpU0S2epvHYUoDrHNJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Itf7GHzR; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Itf7GHzR" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 105404E42D47; Tue, 26 May 2026 05:54:53 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B77FB60732; Tue, 26 May 2026 05:54:52 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 47FBA108881DE; Tue, 26 May 2026 07:54:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1779774891; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=2kREDJHLsmhhE8imBhUGXJe35E0fWxX/crf+AB4czco=; b=Itf7GHzRlgpkV6OfXnVvoKneyxplAI2bfh1rj0CJ4uwmDYfLn3CeAEKnHb+56tHDqvgm9m Uk2LEsFJZjqpQa9LI8ncCq8p62wB3RDeUO4/XtKJJko8IEblFy48qFG8RKNA6rqQZ7UhE+ jg04u4qvKnGhD4wSclckAOqqDu/s/erKLqPBMQSZk2MeR7moc0ilcn8rEyeOuz8OtkUQf7 s1HfWQry1LopOYSpEr0NnlV3NBGcAvlMRE0iPWHhuoYU76c44qEcNJFogeheoTY9mj1toH c29MBAlQwgqBSAcvhRLQyh9KAouxRudQ8VK4oJGv6qJo2hIbctLl7kS6hnFUUA== Message-ID: Date: Tue, 26 May 2026 07:54:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v11 06/10] net: phy: phy_port: Store information about a port's upstream To: Jakub Kicinski Cc: davem@davemloft.net, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Romain Gantois , Daniel Golle , Dimitri Fedrau , Frank Wunderlich References: <20260521121040.1199622-1-maxime.chevallier@bootlin.com> <20260521121040.1199622-7-maxime.chevallier@bootlin.com> <20260525132537.7fa42301@kernel.org> Content-Language: en-US From: Maxime Chevallier In-Reply-To: <20260525132537.7fa42301@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Jakub, On 5/25/26 22:25, Jakub Kicinski wrote: > On Thu, 21 May 2026 14:10:34 +0200 Maxime Chevallier wrote: >> --- a/include/linux/phy.h >> +++ b/include/linux/phy.h >> @@ -791,6 +791,7 @@ struct phy_device { >> struct sfp_bus *sfp_bus; >> struct phy_port *sfp_cage_port; >> struct phy_port *mod_port; >> + struct phy_port *upstream_port; >> struct phylink *phylink; >> struct net_device *attached_dev; >> struct mii_timestamper *mii_ts; > > nit: missing kdoc here Ah damn, missed that... > > Are all the sashiko reports false positive at this stage? I'm going through them, it's a mixed bag of correct and incorrect stuff, I'll reply inline and followup. Thanks, Maxime