From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C71C1B0F2 for ; Wed, 20 Jun 2018 09:15:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCFE720846 for ; Wed, 20 Jun 2018 09:15:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="b32WYgZq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCFE720846 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=synopsys.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932552AbeFTJPG (ORCPT ); Wed, 20 Jun 2018 05:15:06 -0400 Received: from smtprelay.synopsys.com ([198.182.37.59]:50863 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754315AbeFTJPD (ORCPT ); Wed, 20 Jun 2018 05:15:03 -0400 Received: from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66]) by smtprelay.synopsys.com (Postfix) with ESMTP id 6122B1E04A3; Wed, 20 Jun 2018 11:15:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1529486101; bh=fAPM8umxGuItWPS5vJwUiMglPgzdojeg0EkdvTytikU=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=b32WYgZqaVNNUd8OZ3qgDw3GyDaUVXjIBVP087NVGZdk0h75qcBRvQJFwTXHehTkp pkLo1UxqIFJKcsVkn9J9rSpPws/sgldfnewHpd554vl2OdTdMuwV86+5lWiCaml69n IRw+59D4+0P911oL0U5FqXZ889IKaNbO+rbKQsSc2ojbE88I32O/fcis6SGKItJKC+ NF9g/f9eQ8DPStJDCMuSTmItI/P1MGKW6Vn1HjEXCDRKr1ATPK5yBqTO8z7cTVCjCI B5JEdTmkmfxnfAEnJOrmuh3FMXQOi/MnTPA5qBjIW2zRxy2Jlb8mIQ8JoLh0XKQ8Gh o9AX5yxxFIgqw== Received: from US01WEHTC2.internal.synopsys.com (us01wehtc2.internal.synopsys.com [10.12.239.237]) by mailhost.synopsys.com (Postfix) with ESMTP id 590B23DF9; Wed, 20 Jun 2018 02:15:00 -0700 (PDT) Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by US01WEHTC2.internal.synopsys.com (10.12.239.237) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 20 Jun 2018 02:13:22 -0700 Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by DE02WEHTCA.internal.synopsys.com (10.225.19.92) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 20 Jun 2018 11:13:21 +0200 Received: from [10.107.25.102] (10.107.25.102) by DE02WEHTCB.internal.synopsys.com (10.225.19.80) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 20 Jun 2018 11:13:20 +0200 Subject: Re: [PATCH v4 03/10] PCI: Update xxx_pcie_ep_raise_irq() and pci_epc_raise_irq() signatures To: kbuild test robot , Gustavo Pimentel CC: "kbuild-all@01.org" , "bhelgaas@google.com" , "lorenzo.pieralisi@arm.com" , "Joao.Pinto@synopsys.com" , "jingoohan1@gmail.com" , "kishon@ti.com" , "adouglas@cadence.com" , "jesper.nilsson@axis.com" , "linux-pci@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <5bfa0cf053878e0e859a8b97227ca03ea4d50e92.1529329262.git.gustavo.pimentel@synopsys.com> <201806190312.UKq0zYJ1%fengguang.wu@intel.com> From: Gustavo Pimentel Message-ID: Date: Wed, 20 Jun 2018 10:11:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201806190312.UKq0zYJ1%fengguang.wu@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.25.102] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thanks for the suggestion. Regards, Gustavo On 18/06/2018 20:31, kbuild test robot wrote: > Hi Gustavo, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on pci/next] > [also build test WARNING on v4.18-rc1 next-20180618] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_0day-2Dci_linux_commits_Gustavo-2DPimentel_Add-2DMSI-2DX-2Dsupport-2Don-2Dpcitest-2Dtool_20180619-2D004625&d=DwIBAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=bkWxpLoW-f-E3EdiDCCa0_h0PicsViasSlvIpzZvPxs&m=IFx9JKJsE2KvE7siiXs4GRW2a3OkFpE8BFO41SbTjJA&s=vuOhITY-_4Y-jxzyQ1ddb6M8E9-OELpKXzcJZqgWqvE&e= > base: https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_pub_scm_linux_kernel_git_helgaas_pci.git&d=DwIBAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=bkWxpLoW-f-E3EdiDCCa0_h0PicsViasSlvIpzZvPxs&m=IFx9JKJsE2KvE7siiXs4GRW2a3OkFpE8BFO41SbTjJA&s=7xs_oUDvo5HRxpqsZAqdybMJcJDO6K3hooyy-CmXwkM&e= next > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig > make C=1 CF=-D__CHECK_ENDIAN__ > > > sparse warnings: (new ones prefixed by >>) > > drivers/pci/controller/pcie-rockchip-ep.c:173:14: sparse: expression using sizeof(void) >>> drivers/pci/controller/pcie-rockchip-ep.c:516:27: sparse: incorrect type in initializer (incompatible argument 4 (different type sizes)) @@ expected int ( *raise_irq )( ... ) @@ got int ( *raise_irq )( ... ) @@ > drivers/pci/controller/pcie-rockchip-ep.c:516:27: expected int ( *raise_irq )( ... ) > drivers/pci/controller/pcie-rockchip-ep.c:516:27: got int ( * )( ... ) > drivers/pci/controller/pcie-rockchip-ep.c:516:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] > .raise_irq = rockchip_pcie_ep_raise_irq, > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/pci/controller/pcie-rockchip-ep.c:516:15: note: (near initialization for 'rockchip_pcie_epc_ops.raise_irq') > cc1: some warnings being treated as errors > > vim +516 drivers/pci/controller/pcie-rockchip-ep.c > > cf590b07 drivers/pci/host/pcie-rockchip-ep.c Shawn Lin 2018-05-09 507 > cf590b07 drivers/pci/host/pcie-rockchip-ep.c Shawn Lin 2018-05-09 508 static const struct pci_epc_ops rockchip_pcie_epc_ops = { > cf590b07 drivers/pci/host/pcie-rockchip-ep.c Shawn Lin 2018-05-09 509 .write_header = rockchip_pcie_ep_write_header, > cf590b07 drivers/pci/host/pcie-rockchip-ep.c Shawn Lin 2018-05-09 510 .set_bar = rockchip_pcie_ep_set_bar, > cf590b07 drivers/pci/host/pcie-rockchip-ep.c Shawn Lin 2018-05-09 511 .clear_bar = rockchip_pcie_ep_clear_bar, > cf590b07 drivers/pci/host/pcie-rockchip-ep.c Shawn Lin 2018-05-09 512 .map_addr = rockchip_pcie_ep_map_addr, > cf590b07 drivers/pci/host/pcie-rockchip-ep.c Shawn Lin 2018-05-09 513 .unmap_addr = rockchip_pcie_ep_unmap_addr, > cf590b07 drivers/pci/host/pcie-rockchip-ep.c Shawn Lin 2018-05-09 514 .set_msi = rockchip_pcie_ep_set_msi, > cf590b07 drivers/pci/host/pcie-rockchip-ep.c Shawn Lin 2018-05-09 515 .get_msi = rockchip_pcie_ep_get_msi, > cf590b07 drivers/pci/host/pcie-rockchip-ep.c Shawn Lin 2018-05-09 @516 .raise_irq = rockchip_pcie_ep_raise_irq, > cf590b07 drivers/pci/host/pcie-rockchip-ep.c Shawn Lin 2018-05-09 517 .start = rockchip_pcie_ep_start, > cf590b07 drivers/pci/host/pcie-rockchip-ep.c Shawn Lin 2018-05-09 518 }; > cf590b07 drivers/pci/host/pcie-rockchip-ep.c Shawn Lin 2018-05-09 519 > > :::::: The code at line 516 was first introduced by commit > :::::: cf590b07839133146842d2d3d9a68f804c2edc4b PCI: rockchip: Add EP driver for Rockchip PCIe controller > > :::::: TO: Shawn Lin > :::::: CC: Lorenzo Pieralisi > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.01.org_pipermail_kbuild-2Dall&d=DwIBAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=bkWxpLoW-f-E3EdiDCCa0_h0PicsViasSlvIpzZvPxs&m=IFx9JKJsE2KvE7siiXs4GRW2a3OkFpE8BFO41SbTjJA&s=Mf1d7cz8MbsSZPkgXFwnxZJY1579nwc7-mpjeQBdweY&e= Intel Corporation >