From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754214AbdBNOcU (ORCPT ); Tue, 14 Feb 2017 09:32:20 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:18441 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754125AbdBNObF (ORCPT ); Tue, 14 Feb 2017 09:31:05 -0500 Subject: Re: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP To: Paul Durrant , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" References: <1487005404-3183-1-git-send-email-paul.durrant@citrix.com> <1487005404-3183-3-git-send-email-paul.durrant@citrix.com> <0ae0162c-4317-7dbf-fdce-354f71583d0a@oracle.com> <9328bb49eb634b0994e41f19733a373e@AMSPEX02CL03.citrite.net> Cc: Juergen Gross From: Boris Ostrovsky Message-ID: Date: Tue, 14 Feb 2017 09:11:55 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <9328bb49eb634b0994e41f19733a373e@AMSPEX02CL03.citrite.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/14/2017 04:20 AM, Paul Durrant wrote: > My previous reply got bounced because my tablet insisted on using HTML... > >> -----Original Message----- >> >> These need to be static. (I can fix it when committing.) > > Ok, thanks. > >> >> And I am still not sure about using XEN_PAGE_SIZE. There is no >> dependency in the hypervisor on buffers being page-sized, is there? If >> not, XEN_PAGE_SIZE is here just because it happens to be 4K, which is a >> reasonable value. >> >> How about just setting it to 4096? >> > > I chose XEN_PAGE_SIZE because the hypercall will eventually copy in the buffer so it seemed like a reasonable value to use. If you want to just use 4096 then I am ok with that. > > Paul > > PS: If you want to change from XEN_PAGE_SIZE to 4096 then I assume you are happy to do this at commit and don't need me to send a v4? Right. But I also had a question about patch 3 (commit message). I can make the change when committing as well but I need to make sure you are OK with it. -boris