From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752420AbeADMkn (ORCPT + 1 other); Thu, 4 Jan 2018 07:40:43 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:61799 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbeADMkm (ORCPT ); Thu, 4 Jan 2018 07:40:42 -0500 Subject: Re: [PATCH v4 6/7] ARM: davinci: convert to common clock framework To: David Lechner , CC: Kevin Hilman , Adam Ford , References: <1514763588-31560-1-git-send-email-david@lechnology.com> <1514763588-31560-7-git-send-email-david@lechnology.com> From: Sekhar Nori Message-ID: Date: Thu, 4 Jan 2018 18:09:31 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1514763588-31560-7-git-send-email-david@lechnology.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Monday 01 January 2018 05:09 AM, David Lechner wrote: > This converts all of arch/arm/mach-davinci to the common clock framework. > The clock drivers from clock.c and psc.c have been moved to drivers/clk, > so these files are removed. > > There is one subtle change in the clock trees. AUX, BPDIV and OSCDIV > clocks now have "ref_clk" as a parent instead of the PLL clock. These > clocks are part of the PLL's MMIO block, but they bypass the PLL and > therefore it makes more sense to have "ref_clk" as their parent since > "ref_clk" is the input clock of the PLL. > > CONFIG_DAVINCI_RESET_CLOCKS is removed since the common clock frameworks > takes care of disabling unused clocks. > > Known issue: This breaks CPU frequency scaling on da850. This functionality needs to be restored as part of this series since we cannot commit anything with regressions. > > Also, the order of #includes are cleaned up in files while we are touching > this code. > > Signed-off-by: David Lechner This is a pretty huge patch again and I hope it can be broken down. Ideally one per SoC converted and then the unused code removal. Thanks, Sekhar