From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE931C7EE26 for ; Tue, 23 May 2023 02:34:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234701AbjEWCe2 (ORCPT ); Mon, 22 May 2023 22:34:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232034AbjEWCe1 (ORCPT ); Mon, 22 May 2023 22:34:27 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 222D4CA; Mon, 22 May 2023 19:34:26 -0700 (PDT) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QQJDz4mTWzqTNG; Tue, 23 May 2023 10:29:55 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 10:34:23 +0800 Subject: Re: [PATCH net] page_pool: fix inconsistency for page_pool_ring_[un]lock() To: Jakub Kicinski CC: Ilias Apalodimas , Jesper Dangaard Brouer , , , , , , Jesper Dangaard Brouer , Eric Dumazet , Lorenzo Bianconi , Daniel Borkmann , John Fastabend References: <20230522031714.5089-1-linyunsheng@huawei.com> <1fc46094-a72a-f7e4-ef18-15edb0d56233@redhat.com> <20230522192238.28837d1d@kernel.org> From: Yunsheng Lin Message-ID: Date: Tue, 23 May 2023 10:34:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20230522192238.28837d1d@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/5/23 10:22, Jakub Kicinski wrote: > On Tue, 23 May 2023 10:13:14 +0800 Yunsheng Lin wrote: >> On 2023/5/22 19:45, Ilias Apalodimas wrote: >>>> Thanks for spotting and fixing this! :-) >> >> It was spotted when implementing the below patch:) >> >> https://patchwork.kernel.org/project/netdevbpf/patch/168269857929.2191653.13267688321246766547.stgit@firesoul/#25325801 >> >> Do you still working on optimizing the page_pool destroy >> process? If not, do you mind if I carry it on based on >> that? > > Not sure what you mean, this patch is a fix and the destroy > optimizations where targeted at net-next. Fix goes in first, > and then after the tree merge on Thu the work in net-next can > progress. Sure, it will be sent as RFC if this patch is not merged to net-next yet:)