From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E10E6ECDFB1 for ; Tue, 17 Jul 2018 06:33:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85B7220864 for ; Tue, 17 Jul 2018 06:33:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="oU0PYtCP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85B7220864 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728983AbeGQHEm (ORCPT ); Tue, 17 Jul 2018 03:04:42 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:57944 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727293AbeGQHEl (ORCPT ); Tue, 17 Jul 2018 03:04:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2nNpvIivHdrH9xVVW9Pw7MrAgR16UTBuzKqY2n1lwbg=; b=oU0PYtCPhO/n6jpHSO+RId1C9 HTkMzuHxIHbYGzIc74+3uM5qfOmqKt59acYDitbYZtAHNVI7f0KYKd7x5IWnIcqSYB0sO2rbXWXfZ ogC/72S06WJmZ+NKczdXFIvmo5DU0aTx2l6UMjXfhDZzoo1W6Zwsm7kUnwAMizWHf2GFPBaO18Wdx LAz3ONGGwmsOGHVk9mn0EE/XmiI5Xuh8S5ZLt1HJLP9028y/xH+NDq1wfx47j5gHcL2cQMnU3PNA+ Au2W1ZcaFp31VflIp9kMHMy1WSp/ZMfpKJxVH7aIskDudGIDzbBx6Y9rAPtI04Vr0owCykZrZl1GP C2oRqrT6w==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=dragon.dunlab) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1ffJYK-0006qw-76; Tue, 17 Jul 2018 06:33:40 +0000 Subject: Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig To: Masahiro Yamada , Christoph Hellwig Cc: Richard Weinberger , Linux Kbuild mailing list , linux-um@lists.infradead.org, Linux Kernel Mailing List References: <20180708152004.21679-1-hch@lst.de> <20180708152004.21679-5-hch@lst.de> From: Randy Dunlap Message-ID: Date: Mon, 16 Jul 2018 23:33:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11/2018 05:21 AM, Masahiro Yamada wrote: > 2018-07-09 0:19 GMT+09:00 Christoph Hellwig : >> Instead of duplicating the source statements in every architecture just >> do it once in the toplevel Kconfig file. >> >> Note that with this the inclusion of arch/$(SRCARCH/Kconfig moves out of >> the top-level Kconfig into arch/Kconfig so that don't violate ordering >> constraits while keeping a sensible menu structure. >> >> Signed-off-by: Christoph Hellwig > > >> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig >> index dd4f3d3e644f..7ab7b148181b 100644 >> --- a/arch/sh/Kconfig >> +++ b/arch/sh/Kconfig >> @@ -168,10 +168,6 @@ config PGTABLE_LEVELS >> default 3 if X2TLB >> default 2 >> >> -source "init/Kconfig" >> - >> -source "kernel/Kconfig.freezer" >> - >> menu "System type" >> >> # >> @@ -553,8 +549,6 @@ endchoice >> >> endif >> >> -source "arch/sh/mm/Kconfig" > > > I noticed at least sh is broken > because "arch/sh/mm/Kconfig" is no longer included by anyone. > > I am not doing further tests. > Hi, Thanks for noticing that. I have tested all $ARCH (except um) with "allmodconfig" and so far, arch/sh/ is the only one that has a problem. > > Please test *ALL* architectures. > > If possible, matrix tests (arch, config-target), where > arch = arm, arm64, ... > config-target = allyesconfig, allnoconfig, alldefconfig, ... > > > Note: > scripts/diffconf is helpful. > -- ~Randy