From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AC7D21A92F for ; Mon, 30 Mar 2026 13:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774877432; cv=none; b=cTC4KD6eS7gLvs6qj9ntu+Dmc3WxB8/OCxI6BYi9dph/22vWuagAzU8CrGp5JkxaNz/1e4PCOlWl9jKGi9/iaCjCsjxMkbHcRlkGVwk4+1w+6YJxZdI1iE3wUQMIcbscBbagDLAuNCzMiRlSIbjppXdtdXkoAasR4jBOd8pl9zA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774877432; c=relaxed/simple; bh=PWI9pxJMUliAWSxOIp1fSPLGEwUcRFIYY006I5gutzY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EutdZxN3qEidL3FdsigFWwJ2UG0xUfZBkUz+4KLFZHrylJCyVDgzrgdawk63iZdhvlRYrJT7HOgvVI5ezvBmMJYZgotKJFa/qGWiXZ16HM7jn8g4McNHlOoqmXBGi/n734iy/2+C9a2RnDqdlCyoLI5csABhUWX3ZNthLjYMROw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jmQoRjvV; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jmQoRjvV" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5a2a75393e2so3118261e87.2 for ; Mon, 30 Mar 2026 06:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774877429; x=1775482229; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=77WeHT8C34JNWFQ0DtWQQvXMSZXQxoGR8B6oehAckGQ=; b=jmQoRjvVwOVvx6r72QPQI64ow/RiqnyE+p5PAwu+jdfvFRleymitXjvksg+5siCqJH po8FCgj25Yf1EZYgLbW8KaFPpDgrziD/IWpi5OoxsnbtB/hKoOfHvtxMUgCPtqZzSfe+ T+h3DamHNJeRsMyZUaZAExSx8PZh5UuKWacCRTuftDMDxLxBtGiluNAHIku5TE7a4CKv /sYauYVYYqgiGfnmCsdnq7dm4f7awud3DmqHAyfKVwxekQRTG4JE53vFA9Owllt33DcZ wAM9dJRB5D1l1HZ2Ht7sZaBp/LLjeElXSWkV3kMbiqj9Ipk+rzHpFUqhng8UKLmUVDU9 D8Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774877429; x=1775482229; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=77WeHT8C34JNWFQ0DtWQQvXMSZXQxoGR8B6oehAckGQ=; b=U5XBLi65k2o/qphpB4dQm/LrU7A5aw2vinblaaGvXeXfw7KGs2mUCA88bf7+zb1wYm 8WFu0RBHgmmIXcx/vksQU4hJQ1NcgErL53ZflIgPmyJiEYKyVz7+ty5VqLKolNVEPI0r nMcfDlyhjVn6/PONv6Hh0Gsr3NP3z8+79U02Nx5x0F+jrxn3t0C6lt+hV8rvjl1hnrIo iTtmGo3Y0pnBnHB1yUDuOSdcu68124MfFUE7WMYTvAN+nFcovMO9LGbEyXg6figDN9rr WlDXUU+nKZRSITgKFWeooii0jS8PwWHczeEDrZivwCv9hkWHabgQdY5VHVGINxazikhi 7E4Q== X-Forwarded-Encrypted: i=1; AJvYcCVXrV6sNHBCmkkZP4z2EzQw4Enb2qiO5v4vCTTfzO2OIoNu/KtM3hTy3yDRRTi5CkQwGA67lV/046lLMo4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4CgvkOBKbJD6yOj8GWo2AtoLS/fFdD4X5e/ydQh1LYTK4uLYO MBlEMGqOmHb5SvZfCjWz+HzlAFPXip2L3CvkPhs94xfdKh/hE3IEkD7t X-Gm-Gg: ATEYQzydlpS2Qhv/HX93nMTJ8LtBsH3nBeYcrv/9Wy3+G4k5wMY6PW4PRhBWi/BHeUB PHNwB2mCX+MB1tPJWcI/lvqhpHJJf5/4SEQKbYMcTSguX7E5uikCthhc983e6xdRDrMsIZ1f0i2 POK0GnO+FILI5bxYQ7Z51I8FrzAkK35EoCh2FQsEL3HuKkjAMg7Y9dcJjm0NQZGmq2zgf0HVRIw Z7Wue6IHRbU4D8iuqRfuIwOED1vQVc6iijcsZ829yIZ6+ippI2o3dRbORqinxAYOevZQBy87Jot W9aYqqASyG0ZU80SQQF0Nxxe+bwsqoarl1w6ZdU/z0bzZ2k4ij7K7OvmFphjRmrUDZAd2W3Vtz7 an5tXfq6LlQl1495FKDdkQ46j6qPfGmxgPejbtCvqA2P3CX3GoEtFGsH10DkOnbVVaktM0JUOzy Zy6Nr3NEPeVGFj2ydceAapqwhfQOKHVNsq15RpWShGCxiJIKJhExtJEEwDYiddiOnS73XHhaDsq inUVaJZ9HnwHd4V1Q== X-Received: by 2002:a05:6512:3b8f:b0:5a2:a355:aa4e with SMTP id 2adb3069b0e04-5a2ab927773mr5628324e87.31.1774877429070; Mon, 30 Mar 2026 06:30:29 -0700 (PDT) Received: from ?IPV6:2a00:1fa0:2c2:728e:63f1:6154:c8be:fcb7? ([2a00:1fa0:2c2:728e:63f1:6154:c8be:fcb7]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2b13f549dsm1643949e87.14.2026.03.30.06.30.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 06:30:26 -0700 (PDT) Message-ID: Date: Mon, 30 Mar 2026 16:30:25 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: cdns3: gadget: fix NULL pointer dereference in ep_queue To: "Peter Chen (CIX)" , Yongchao Wu Cc: Pawel Laszczak , Roger Quadros , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260328143842.57315-1-yongchao.wu@autochips.com> <20260329013404.116481-1-yongchao.wu@autochips.com> Content-Language: en-US From: Sergey Shtylyov In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/30/26 12:21 PM, Peter Chen (CIX) wrote: [...] >> When the gadget endpoint is disabled or not yet configured, the ep->desc >> pointer can be NULL. This leads to a NULL pointer dereference when >> __cdns3_gadget_ep_queue() is called, causing a kernel crash. >> >> Add a check to return -ESHUTDOWN if ep->desc is NULL, which is the >> standard return code for unconfigured endpoints. >> >> This prevents potential crashes when ep_queue is called on endpoints >> that are not ready. >> >> Signed-off-by: Yongchao Wu > > Add Fixed-by tag and Cc to stable tree please, others: I think you meant the Fixes tag. :-) [...] MBR, Sergey