From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 285D7C41535 for ; Mon, 7 Feb 2022 17:00:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357062AbiBGQ7Z (ORCPT ); Mon, 7 Feb 2022 11:59:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357498AbiBGQoy (ORCPT ); Mon, 7 Feb 2022 11:44:54 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 311C3C0401D5 for ; Mon, 7 Feb 2022 08:44:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644252292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JXASh+EywLGlhAlg4jFsCAK0tQKzE6uQ4u5IHhy56MY=; b=SS9QSkUI+dnDGbx+k0fUyAXHpAD+QwjzccoaVhL7h3ljMvjGzjrtk4gjoyKy0LeTkyZzEd s/ZI36nvE1tyZ24h1kB5ZN3QRFLF6UpoOjoFJzia0Hu41iIAT5cypGrl5jf/lakfPKnP3a KO4LWsGcAp/GHir/BGEqlgOLe2wGQXs= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-660-QDdZk_gWMum78fDu45GQWQ-1; Mon, 07 Feb 2022 11:44:51 -0500 X-MC-Unique: QDdZk_gWMum78fDu45GQWQ-1 Received: by mail-ej1-f72.google.com with SMTP id qq4-20020a17090720c400b006c6a6c55ed6so1933644ejb.12 for ; Mon, 07 Feb 2022 08:44:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=JXASh+EywLGlhAlg4jFsCAK0tQKzE6uQ4u5IHhy56MY=; b=IsbGCzyXV6FprFiV/ono+61aHNXWxQjRIMw+DJeFZeKsjXE7jqaiAF254q6I6Gg50x 036MNAc4qdiWeVRmKDoB9/sxGXGDrXL9jlSGp0PHsTG7GY4GqszC3kwOqd8i0lzq5FWT J+TmHMMrxaMoVROmXTT1KrAFYR7KOZAnq0beZTParRQ1gGvEkHFOnbOyZzmcA6ik7xQ+ b5MTMcSHAYh3EgtpJz+1nCOvvNltKBgsrEzicqA4uVyjt1jvuwQJ47KOP/LrTe0BhSwM yUYRgMRyQz2bSweSL265r5EyJq8pCgFKbi2k2Ywx9dqdaVFTnR6UjXxCT4yHEzK+j1M0 8JNg== X-Gm-Message-State: AOAM530ub8lPtNc9iImmUeJVVg0Ml6ppToxry5FOTLxmvMCsepFx3Da6 aNvXT3azENLvS9AUADWrlaWwZJDroieI/xXLVwSf1hSeSUoPs895fUpSUgP4riKnvmwVxYg7Rgt ARrtYvJ54Zzi4g0OkXg3n6ZzQ X-Received: by 2002:a05:6402:2934:: with SMTP id ee52mr334454edb.9.1644252290076; Mon, 07 Feb 2022 08:44:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJzVIvJoEuJU3wDHneUFudIoStwD9wbzeB68Ef8g+xfhRwzYcSHu/Qp7n8pAhJpWqEyFTe1aww== X-Received: by 2002:a05:6402:2934:: with SMTP id ee52mr334440edb.9.1644252289892; Mon, 07 Feb 2022 08:44:49 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id k24sm3887374ejv.179.2022.02.07.08.44.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Feb 2022 08:44:49 -0800 (PST) Message-ID: Date: Mon, 7 Feb 2022 17:44:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 01/11] Revert "svm: Add warning message for AVIC IPI invalid target" Content-Language: en-US To: Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Zeng Guang , Chao Gao , Maxim Levitsky References: <20220204214205.3306634-1-seanjc@google.com> <20220204214205.3306634-2-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20220204214205.3306634-2-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/4/22 22:41, Sean Christopherson wrote: > Remove a WARN on an "AVIC IPI invalid target" exit, the WARN is trivial > to trigger from guest as it will fail on any destination APIC ID that > doesn't exist from the guest's perspective. > > Don't bother recording anything in the kernel log, the common tracepoint > for kvm_avic_incomplete_ipi() is sufficient for debugging. > > This reverts commit 37ef0c4414c9743ba7f1af4392f0a27a99649f2a. > > Cc: stable@vger.kernel.org > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/svm/avic.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c > index 90364d02f22a..ecc81c48c0ca 100644 > --- a/arch/x86/kvm/svm/avic.c > +++ b/arch/x86/kvm/svm/avic.c > @@ -345,8 +345,6 @@ int avic_incomplete_ipi_interception(struct kvm_vcpu *vcpu) > avic_kick_target_vcpus(vcpu->kvm, apic, icrl, icrh); > break; > case AVIC_IPI_FAILURE_INVALID_TARGET: > - WARN_ONCE(1, "Invalid IPI target: index=%u, vcpu=%d, icr=%#0x:%#0x\n", > - index, vcpu->vcpu_id, icrh, icrl); > break; > case AVIC_IPI_FAILURE_INVALID_BACKING_PAGE: > WARN_ONCE(1, "Invalid backing page\n"); Queued for 5.17, thanks. Paolo