mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Moteen Shah <m-shah@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <conor+dt@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<nm@ti.com>, <ssantosh@kernel.org>, <u-kumar1@ti.com>,
	<gehariprasath@ti.com>, <vigneshr@ti.com>, <afd@ti.com>,
	<a-limaye@ti.com>, <y-abhilashchandra@ti.com>, <johan@kernel.org>,
	<kees@kernel.org>, <jm@ti.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: soc: ti: Document the ti,tda54-mcu-scm-conf binding
Date: Mon, 2 Nov 2026 16:18:16 +0530	[thread overview]
Message-ID: <e3823994-2660-4e9c-96de-40a6d14bda78@ti.com> (raw)
In-Reply-To: <6cecea78-658a-4278-b5c9-228a827583e0@kernel.org>


On 02/11/26 12:34, Krzysztof Kozlowski wrote:
> On 02/11/2026 06:20, Moteen Shah wrote:
>>>> +  ti,proxy-id:
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +    minimum: 0
>>>> +    maximum: 7
>>>> +    description:
>>>> +      Proxy region (0-7) through which this node's clients access
>>>> +      claimable registers and their fault status registers.
>>> I don't get the need of this property. You have a one, specific device, so
>>> why the proxy id would vary per board?
>>>
>>> It also looks like re-implementing access controllers.
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Thanks for the review, Krzysztof. I’ll drop the redundant “binding” from
>> the subject.
>>
>> ti,proxy-id is not intended to vary by board. It selects the proxy
> Then it is implied by compatible, no?
>
>> window used by this Linux instance. One use case we need to support is
>> running two VMs with different proxy IDs, with each VM’s DT describing
>> the proxy it uses.
>> The driver reads the ID from DT and performs register accesses through
>> that proxy; it does not allocate proxy IDs or decide which VM uses which
>> one.
> And if not, my statement still feels applicable.

I think my previous reply did not explain why this property belongs in 
the binding.

In the current design, reg describes the SCM region and ti,proxy-id 
selects one of its proxy windows for this Linux instance. The compatible 
describes the SCM hardware; it does not select a proxy window. Our use 
case is separate VM DTs for two Linux instances using different proxy 
IDs. For a single non-virtualized Linux instance, the DT has one fixed 
ID but it can differ between VM instances. The property selects the view 
used by the driver; it does not allocate or grant access to a proxy. The 
information to the driver about the proxy via which it is supposed to 
perform the claim/lock operations, need to be supplied for a particular 
VM instance. I think DT would be the right way to do it. If you think 
some other way would be better please feel free to suggest.

Regards,
Moteen



  reply	other threads:[~2026-11-02 10:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27  8:36 [PATCH v2 0/3] soc: ti: Add TDA54 SCM configuration syscon support Moteen Shah
2026-10-27  8:36 ` [PATCH v2 1/3] dt-bindings: soc: ti: Document the ti,tda54-mcu-scm-conf binding Moteen Shah
2026-10-28 12:24   ` Krzysztof Kozlowski
2026-11-02  5:20     ` Moteen Shah
2026-11-02  7:04       ` Krzysztof Kozlowski
2026-11-02 10:48         ` Moteen Shah [this message]
2026-10-27  8:36 ` [PATCH v2 2/3] soc: ti: k3-socinfo: Export SoC registration helper Moteen Shah
2026-10-27  8:37 ` [PATCH v2 3/3] soc: ti: Add TDA54 SCM configuration syscon support Moteen Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3823994-2660-4e9c-96de-40a6d14bda78@ti.com \
    --to=m-shah@ti.com \
    --cc=a-limaye@ti.com \
    --cc=afd@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gehariprasath@ti.com \
    --cc=jm@ti.com \
    --cc=johan@kernel.org \
    --cc=kees@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    --cc=y-abhilashchandra@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®