From: Mark Brown <broonie@kernel.org>
To: Praveen Talari <praveen.talari@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v2 2/2] spi: qcom-geni: add GENI SE registers trace event on error paths
Date: Tue, 14 Jul 2026 11:24:11 +0100 [thread overview]
Message-ID: <e387d140-72dd-4db0-8cf4-7de290e8b208@sirena.org.uk> (raw)
In-Reply-To: <788b1ebb-db13-4f6f-9e92-46802d7027f6@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On Tue, Jul 14, 2026 at 10:51:42AM +0530, Praveen Talari wrote:
> On 13-07-2026 16:16, Mark Brown wrote:
> > > > SE_GENI_TX_WATERMARK_REG is one of the registers in the tracepoint,
> > > > perhaps trace before we write to clear it?
> > > it will be captured in m_irq register so it is not required to capture.
> > Are you sure that won't lead to user confusion?
> No since m_irq can capture most of other bits as well.
The point isn't that the data isn't somewhere else, the point is that
the user might look at the watermark value and not remember that in this
one specific case they need to check something else.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-07-14 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 18:48 [PATCH v2 0/2] Add trace event support for GENI SE registers dump Praveen Talari
2026-07-10 18:48 ` [PATCH v2 1/2] soc: qcom: geni-se: trace: " Praveen Talari
2026-07-11 15:54 ` Bjorn Andersson
2026-07-10 18:48 ` [PATCH v2 2/2] spi: qcom-geni: add GENI SE registers trace event on error paths Praveen Talari
2026-07-10 21:26 ` Mark Brown
2026-07-11 2:54 ` Praveen Talari
[not found] ` <4bcaa245-2127-45aa-bf05-48e275c0129c@oss.qualcomm.com>
2026-07-13 10:46 ` Mark Brown
2026-07-14 5:21 ` Praveen Talari
2026-07-14 10:24 ` Mark Brown [this message]
2026-07-14 15:34 ` Praveen Talari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e387d140-72dd-4db0-8cf4-7de290e8b208@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=praveen.talari@oss.qualcomm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®