From: cuigaosheng <cuigaosheng1@huawei.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<puwen@hygon.cn>, <TonyWWang-oc@zhaoxin.com>,
<peterz@infradead.org>, <gregkh@linuxfoundation.org>,
<andrew.cooper3@citrix.com>, <tony.luck@intel.com>,
<mario.limonciello@amd.com>, <pawan.kumar.gupta@linux.intel.com>,
<chenyi.qiang@intel.com>, <rdunlap@infradead.org>,
<jithu.joseph@intel.com>, <rafael.j.wysocki@intel.com>,
<paulmck@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] x86/cpu: replacing the open-coded shift with BIT(x)
Date: Tue, 1 Nov 2022 22:05:21 +0800 [thread overview]
Message-ID: <e38b1702-c29a-96fc-8fa2-139006fd4d27@huawei.com> (raw)
In-Reply-To: <CAHmME9rNE-fWcdJer-MsQJ224redaXJO-Vvcjy6xg0_Eib-RZQ@mail.gmail.com>
Yes, maybe we can do the same thing with BIT(), so I add other modifications, should I remove them?
Thanks very much!
On 2022/11/1 21:43, Jason A. Donenfeld wrote:
> On Tue, Nov 1, 2022 at 2:37 PM cuigaosheng <cuigaosheng1@huawei.com> wrote:
>>> 215 [ 0.953146][ T0] UBSAN: shift-out-of-bounds in mm/shmem.c:3749:18
>>> 216 [ 0.953863][ T0] left shift of 1 by 31 places cannot be represented in type 'int'
> Isn't this just an issue with `1 << 31` needing to be `1U << 31`?
>
> Jason
> .
prev parent reply other threads:[~2022-11-01 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 11:14 Gaosheng Cui
2022-11-01 11:34 ` Jason A. Donenfeld
2022-11-01 13:37 ` cuigaosheng
2022-11-01 13:43 ` Jason A. Donenfeld
2022-11-01 14:05 ` cuigaosheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e38b1702-c29a-96fc-8fa2-139006fd4d27@huawei.com \
--to=cuigaosheng1@huawei.com \
--cc=Jason@zx2c4.com \
--cc=TonyWWang-oc@zhaoxin.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=chenyi.qiang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jithu.joseph@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=puwen@hygon.cn \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®