mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "thorsten.scherer@eckelmann.de" <thorsten.scherer@eckelmann.de>
Cc: "mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 40/62] gpio: gpio-siox: Use new GPIO_LINE_DIRECTION
Date: Mon, 11 Nov 2019 07:43:50 +0000	[thread overview]
Message-ID: <e38b59d9c8bcf81bbd49fed2d9d17350d4dc4866.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20191111072715.GB4117@ws067.eckelmann.group>

Hello Thorsten,

On Mon, 2019-11-11 at 08:27 +0100, Thorsten Scherer wrote:
> Hello,
> 
> On Tue, Nov 05, 2019 at 12:30:58PM +0200, Matti Vaittinen wrote:
> > It's hard for occasional GPIO code reader/writer to know if values
> > 0/1
> > equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and
> > GPIO_LINE_DIRECTION_OUT to help them out.
> > 
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> 
> for SIOX gpio:
> 
> Acked-by: Thorsten Scherer <t.scherer@eckelmann.de>
> 
> > Patches are compile-tested only. I have no HW to really test
> > them.  Thus
> > I'd appreciate carefull review. This work is mainly about
> > converting
> > zeros and ones to the new defines but it wouldn't be first time I
> > get it wrong in one of the patches
> > :)                                                   
> 
> Applied the patch(es) and tested them with SIOX device
> 
> Tested-by: Thorsten Scherer <t.scherer@eckelmann.de>
> 

Big thanks! It's _really_ nice that someone takes the time to do the
testing! Highly appreciated! :]

Br,
	Matti Vaittinen

  reply	other threads:[~2019-11-11  7:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1572945896.git.matti.vaittinen@fi.rohmeurope.com>
2019-11-05 10:30 ` Matti Vaittinen
2019-11-11  7:27   ` Thorsten Scherer
2019-11-11  7:43     ` Vaittinen, Matti [this message]
2019-11-11 10:42       ` Uwe Kleine-König
2019-11-13  8:46         ` Matti Vaittinen
2019-11-13  9:09           ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e38b59d9c8bcf81bbd49fed2d9d17350d4dc4866.camel@fi.rohmeurope.com \
    --to=matti.vaittinen@fi.rohmeurope.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=thorsten.scherer@eckelmann.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®