From: Alexandru Dadu <Alexandru.Dadu@imgtec.com>
To: "gye976@gmail.com" <gye976@gmail.com>
Cc: Luigi Santivetti <Luigi.Santivetti@imgtec.com>,
"imagination@lists.freedesktop.org"
<imagination@lists.freedesktop.org>,
"simona@ffwll.ch" <simona@ffwll.ch>,
"tzimmermann@suse.de" <tzimmermann@suse.de>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"airlied@gmail.com" <airlied@gmail.com>,
Alessio Belle <Alessio.Belle@imgtec.com>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"mripard@kernel.org" <mripard@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH 1/2] drm/imagination: Switch to kernel-style MMU defines and access
Date: Tue, 6 Oct 2026 07:24:40 +0000 [thread overview]
Message-ID: <e392fbc385bf5db80287c1a82892648cbd57978b.camel@imgtec.com> (raw)
In-Reply-To: <CAKbEznsnKevHokY-ip6g7+TG+NQLJcKxaYEbqsKa47dM26s6QA@mail.gmail.com>
On Sat, 2026-10-03 at 19:55 +0900, Gyeyoung Baek wrote:
> *** CAUTION: This email originates from a source not known to
> Imagination Technologies. Think before you click a link or open an
> attachment ***
>
> Hi Alexandru,
>
> >
> > /**
> > @@ -442,18 +424,18 @@ pvr_page_table_l2_entry_raw_is_valid(struct
> > pvr_page_table_l2_entry_raw entry)
> > * associated with @entry.
> > *
> > * When calling this function, @child_table_dma_addr must be a
> > valid DMA
> > - * address and a multiple of
> > %ROGUE_MMUCTRL_PC_DATA_PD_BASE_ALIGNSIZE.
> > + * address and a multiple of %ROGUE_MMUCTRL_PC_DATA_PD_BASE_ALIGN.
> > */
>
> nit: ALIGN is now a shift, so "a multiple of" in this comment no
> longer fits.
Hi Gyeyoung,
Thank you for the review!
Regarding the nit remark, ALIGNSIZE was also a shift before changing it
to ALIGN.
>
> Reviewed-by: Gyeyoung Baek <gye976@gmail.com>
>
Thanks,
Alexandru Dadu
next prev parent reply other threads:[~2026-10-06 7:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 11:43 [PATCH 0/2] drm/imagination: MMU defines updates and improvements Alexandru Dadu
2026-09-30 11:43 ` [PATCH 1/2] drm/imagination: Switch to kernel-style MMU defines and access Alexandru Dadu
2026-10-03 10:55 ` Gyeyoung Baek
2026-10-06 7:24 ` Alexandru Dadu [this message]
2026-10-06 8:34 ` [EXTERNAL] " Gyeyoung Baek
2026-09-30 11:43 ` [PATCH 2/2] drm/imagination: Don't include MMU defines outside of MMU code Alexandru Dadu
2026-10-03 10:56 ` Gyeyoung Baek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e392fbc385bf5db80287c1a82892648cbd57978b.camel@imgtec.com \
--to=alexandru.dadu@imgtec.com \
--cc=Alessio.Belle@imgtec.com \
--cc=Luigi.Santivetti@imgtec.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gye976@gmail.com \
--cc=imagination@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®