mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Lu Hongfei <luhongfei@vivo.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Stanley Chu <stanley.chu@mediatek.com>,
	Can Guo <quic_cang@quicinc.com>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Asutosh Das <quic_asutoshd@quicinc.com>,
	Po-Wen Kao <powen.kao@mediatek.com>,
	Eric Biggers <ebiggers@google.com>,
	Arthur Simchaev <Arthur.Simchaev@wdc.com>,
	Keoseong Park <keosung.park@samsung.com>,
	linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com
Subject: Re: [PATCH 2/3] scsi: ufs: core: allow host driver to enable wb buffer resize function
Date: Thu, 7 Sep 2023 06:45:31 -0700	[thread overview]
Message-ID: <e39a18d2-7abe-4de8-a57c-980f859d79df@acm.org> (raw)
In-Reply-To: <20230907073622.1731-1-luhongfei@vivo.com>

On 9/7/23 00:35, Lu Hongfei wrote:
> Since UFS4.1 will support the WB buffer resize function, the host could
> choose to enable or disable it as needed.
> 
> Introduce a flag UFSHCD_CAP_WB_BUF_RESIZE to provide the host with the
> ability to enable or disable WB buffer resize function.
> 
> UFSHCD_CAP_WB_BUF_RESIZE is only valid when UFSHCD_CAP_WB_EN is set.

Please drop this patch. It should be sufficient that WB buffer resizing
can be controlled via sysfs. I don't think that the host driver should
be able to decide whether or not this functionality is enabled.

Additionally, when reposting this patch series, please include a cover
letter such that e-mail clients that support threading group these
patches into a series.

Thanks,

Bart.

      reply	other threads:[~2023-09-07 15:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07  7:35 Lu Hongfei
2023-09-07 13:45 ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e39a18d2-7abe-4de8-a57c-980f859d79df@acm.org \
    --to=bvanassche@acm.org \
    --cc=Arthur.Simchaev@wdc.com \
    --cc=ebiggers@google.com \
    --cc=keosung.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luhongfei@vivo.com \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=opensource.kernel@vivo.com \
    --cc=powen.kao@mediatek.com \
    --cc=quic_asutoshd@quicinc.com \
    --cc=quic_cang@quicinc.com \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®