From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 406D41CB30A for ; Tue, 1 Oct 2024 14:13:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727792030; cv=none; b=CfW4PdTnqnO1yBzAAz2bt/o8rYtL2MlocANOTk01r3v6mCHfG0SwXSv7hQzWIDWbyzA/4ISwPfEjIwabARrGXQr8gnP3Pdk5UhEGHD25I81Fsf5fzwsBX/Ftu/x7aAdi5Eac1Sn4ipZvFP+aLGolmtQZKZ7nKIAX2XdyGF8YSRM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727792030; c=relaxed/simple; bh=XY8ZzKIJln9Dg1OjlPScukFH2zoKtdG7bx31O314oeA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s30mnGYR8qG5lX95f7obzh2pmtUeS+ajd09yjgTRTSY8LGhnAvIYTIT1bHNSy/+pBTxYUacdbcew3q423cr/w4Osw/4VpX87xTGqi7+7jk48X3nJmk5wJS23CFiPOKGs2UfkY5i/hbMOFiHWlTTL/cC2Pl6/4N1TB+GTXs9xR9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=K7L6oZi8; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="K7L6oZi8" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5c5bca6603aso6718732a12.1 for ; Tue, 01 Oct 2024 07:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1727792027; x=1728396827; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n+AC5fWKlNBJp4jGjiPsZYEshdzlIiLPjFPjK9CcGHI=; b=K7L6oZi8YcQaPPad6xbRrBDnQMa/yKSNzLRIcvvbA6oihyQUml/SZtnb/JYcVn42ci eTKcWXPIXY1lh1OAGEIz0ufJRyXjNMIBrJERtcVEgjvZk5RxJf7OEnnrSxbf0UeySJtW 8sdk/Rtrayr8C4I/NGu/houIg5F+GFQBvTF4xFgVqEY96y3iWyP9bklrYRflo4ER1mDx xDQN12nbWlyLK/yVklRb9XliU8UERQ/cNstNz7jaidGEVYBPw1cHP6bZ2onYWTC2lowB WzVPtkNWwUQX+ZF1rLy6K2d8S/opJea0U/jcRF11mQmsNzkYSCAQ0gQ48sGqtgnN2NRx MW9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727792027; x=1728396827; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n+AC5fWKlNBJp4jGjiPsZYEshdzlIiLPjFPjK9CcGHI=; b=fN2bo9/bzY2JMR7H+477OzR2DuKmc0JkGNzRkgiwtbFRBClk47MH0eDv9n/2VnDSEe 8bMJyCJ7XR65UHSlB6DkFZI5lsv4uePDnwJmOvFYPOBjQisUw9ASa04qr838zvtn5fDM uQeG2nLxWzGFrzvOuD18CeC/hAqevq2sJlDUpsIJujyAbIFVE54AzSONkLBReHus5xyq J+4gqJL4O/Cazo9bbFxOjGYUqgssG9v/VBXgV4kIR05geNdz4qOkrSmzWQ24tJDdAcFk QJ9Utk/c/hW7+2TOhGFaSQ+cBBphDsW8b6DUUzAgxz0gCMo8WcBCMGulbg7KZkEJXNNA HZKw== X-Forwarded-Encrypted: i=1; AJvYcCW8/cnoso71Vr1s8JJXygwggsnbc5X2iyUY0gelxUilT5OSojBuFF8YVikt8vmtyNFVZfevOnoYU5qInXQ=@vger.kernel.org X-Gm-Message-State: AOJu0YydW2i8FPz6eZdBGawsuz1sGHdjdVg6GUvbJcR32Fi9nTOxNoZy mi1/vsBRf19+9xy1wAQf6s/lcUp+LNsOuCAenx5YJHMn8iIXmTGgxIHuXS2pcn4= X-Google-Smtp-Source: AGHT+IEMZmc8txKJvmq0HUIkU/EyEg0oAsdYMXagzUOgzgVDeHf+VoEn9MCuGw/Fb5bAjra+vroY0Q== X-Received: by 2002:a17:907:6e92:b0:a93:c2b0:f965 with SMTP id a640c23a62f3a-a93c4ab2afamr1666487066b.41.1727792026569; Tue, 01 Oct 2024 07:13:46 -0700 (PDT) Received: from [10.100.51.161] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a93c27776a1sm721237366b.8.2024.10.01.07.13.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Oct 2024 07:13:46 -0700 (PDT) Message-ID: Date: Tue, 1 Oct 2024 16:13:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 09/20] gendwarfksyms: Expand array_type To: Sami Tolvanen Cc: Masahiro Yamada , Luis Chamberlain , Miguel Ojeda , Greg Kroah-Hartman , Matthew Maurer , Alex Gaynor , Wedson Almeida Filho , Gary Guo , Petr Pavlu , Neal Gompa , Hector Martin , Janne Grunau , Miroslav Benes , Asahi Linux , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, rust-for-linux@vger.kernel.org References: <20240923181846.549877-22-samitolvanen@google.com> <20240923181846.549877-31-samitolvanen@google.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20240923181846.549877-31-samitolvanen@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/23/24 20:18, Sami Tolvanen wrote: > Add support for expanding DW_TAG_array_type, and the subrange type > indicating array size. > > Example source code: > > const char *s[34]; > > Output with --dump-dies: > > variable array_type[34] { > pointer_type { > const_type { > base_type char byte_size(1) encoding(6) > } > } byte_size(8) > } > > Signed-off-by: Sami Tolvanen > [...] Looks ok to me, feel free to add: Reviewed-by: Petr Pavlu -- Thanks, Petr