Re: [PATCH v3 0/4] Add Qualcomm SPEL powercap driver

[Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>]

Hi Rafael,

More qcom powercap drivers will come in the future. After discussing 
internally we agreed I can maintain them, if you are ok with that.

I'm wondering if it would make sense to create a qcom directory under 
powercap in order to group those drivers under the same maintainer 
umbrella (and perhaps do the same grouping for other drivers?)


On 7/2/26 19:22, Manaf Meethalavalappu Pallikunhi wrote:
> This patch series introduces support for Qualcomm's SPEL (SoC Power
> and Electrical Limits) hardware, which provides power monitoring and
> limiting capabilities for various power domains in Qualcomm SoCs.
> 
> The SPEL hardware enables:
> - Real-time energy consumption monitoring across multiple power domains
> - Hardware-enforced power limits with configurable time windows
> - Support for up to 4 power limits (PL1-PL4) per domain
> - Hierarchical power domain organization (SYS -> SOC -> subsystems)
> 
> The driver integrates with the Linux powercap framework, exposing SPEL
> capabilities through standard sysfs interfaces. This allows userspace
> applications and thermal management daemons to monitor energy consumption
> and configure power limits for optimal power/performance balance.
> 
> This series introduces a new power/limits directory for power limit
> controller bindings. The power-limit-controller.yaml schema is added to
> MAINTAINERS under "QUALCOMM SPEL POWERCAP DRIVER" in patch 2/X alongside
> the SPEL device specific binding, as this is its primary use case.
> 
> Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
> ---
> Changes in v3:
> - Created common power-limit-controller schema under power/limits and described
>    power-limit-controller device common capabilities.(Krzysztof)
> - Created SoC-specific qcom,glymur-spel.yaml file instead of generic one and updated
>    description and commit.(Krzysztof)
> - Used FIELD_MODIFY() macro at different places.(Konrad)
> - Updated glymur specific domain info table.(Konrad)
> - Updated all for-loops iterator declaration to C99 style.(Konrad)
> - Fixed use-after-free bugs.(Sashiko)
> - Corrected time_unit documention to reflect the logic.(Sashiko)
> - Link to v2: https://lore.kernel.org/r/20260620-qcom_spel_driver_upstream-v2-0-a3ee6837c18f@oss.qualcomm.com
> 
> Changes in v2:
> - Fixed DT issues: corrected unit-address mismatch and made compatible
>    platform-specific.(Konrad/Krzysztof)
> - Cleaned up bitfield handling: switched to GENMASK, FIELD_* macros.(Konrad)
> - Converted hex values to lowercase and simplified array definitions.(Konrad)
> - used devm_platform_ioremap_resource_byname().(Konrad)
> - Refactored data structures: merged domain data into spel_domain_info
>    and removed hardcoded limits using ARRAY_SIZE().(Daniel)
> - Added bounds checks (TIME_WINDOW_MAX) and fixed time window RMW
>    handling (preserving reserved bits + firmware notify).(Sashiko)
> - Resolved use-after-free, replaced allocation strategy, and
>    added proper cleanup in .release().(Sashiko)
> - Updated time window calculation logic.
> - Removed cyclic dependency, improved validation logic, and aligned
>    naming consistency.(Daniel)
> - Link to v1: https://lore.kernel.org/r/20260519-qcom_spel_driver_upstream-v1-0-75356d1b7f94@oss.qualcomm.com
> 
> ---
> Manaf Meethalavalappu Pallikunhi (4):
>        dt-bindings: power: Add common power limit controller schema
>        dt-bindings: power: limits: Describe Qualcomm SPEL hardware
>        powercap: qcom: Add SPEL powercap driver
>        arm64: dts: qcom: glymur: Enable SPEL powercap driver
> 
>   .../power/limits/power-limit-controller.yaml       |  34 +
>   .../bindings/power/limits/qcom,glymur-spel.yaml    |  61 ++
>   MAINTAINERS                                        |   8 +
>   arch/arm64/boot/dts/qcom/glymur.dtsi               |  10 +
>   drivers/powercap/Kconfig                           |  13 +
>   drivers/powercap/Makefile                          |   1 +
>   drivers/powercap/qcom_spel.c                       | 803 +++++++++++++++++++++
>   7 files changed, 930 insertions(+)
> ---
> base-commit: 4f441960e691d37c880d2cc004de06bb5b6bd5e4
> change-id: 20260702-qcom_spel_driver_upstream-909d37c8d8e8
> 
> Best regards,