From: Jens Axboe <axboe@kernel.dk>
To: Eric Dumazet <edumazet@google.com>,
syzbot <syzbot+8836466a79f4175961b0@syzkaller.appspotmail.com>,
Christoph Hellwig <hch@lst.de>
Cc: changbin.du@intel.com,
Christian Brauner <christian.brauner@ubuntu.com>,
Daniel Borkmann <daniel@iogearbox.net>,
David Miller <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-block@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
Yajun Deng <yajun.deng@linux.dev>
Subject: Re: [syzbot] general protection fault in set_task_ioprio
Date: Tue, 21 Dec 2021 08:25:04 -0700 [thread overview]
Message-ID: <e3a30c8c-3f1a-47b5-57e7-1b456bbc8719@kernel.dk> (raw)
In-Reply-To: <CANn89i++5O_4_j3KO0wAiJHkEj=1zAeAHv=s9Lub_B6=cguwXQ@mail.gmail.com>
On 12/21/21 3:44 AM, Eric Dumazet wrote:
> On Tue, Dec 21, 2021 at 1:52 AM syzbot
> <syzbot+8836466a79f4175961b0@syzkaller.appspotmail.com> wrote:
>>
>> syzbot has bisected this issue to:
>>
>> commit e4b8954074f6d0db01c8c97d338a67f9389c042f
>> Author: Eric Dumazet <edumazet@google.com>
>> Date: Tue Dec 7 01:30:37 2021 +0000
>>
>> netlink: add net device refcount tracker to struct ethnl_req_info
>>
>
> Unfortunately this commit will be in the way of many bisections.
>
> Real bug was added in
>
> commit 5fc11eebb4a98df5324a4de369bb5ab7f0007ff7
> Author: Christoph Hellwig <hch@lst.de>
> Date: Thu Dec 9 07:31:29 2021 +0100
>
> block: open code create_task_io_context in set_task_ioprio
>
> The flow in set_task_ioprio can be simplified by simply open coding
> create_task_io_context, which removes a refcount roundtrip on the I/O
> context.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Link: https://lore.kernel.org/r/20211209063131.18537-10-hch@lst.de
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
There are only really 5 patches in between the broken commit and the one
that fixes it, and it only affects things trying to set the ioprio with
a dead task. Is this a huge issue? I don't see why this would cause a
lot of bisection headaches.
--
Jens Axboe
next prev parent reply other threads:[~2021-12-21 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 3:04 syzbot
2021-12-21 3:34 ` Jens Axboe
2021-12-21 5:21 ` syzbot
2021-12-21 9:52 ` syzbot
2021-12-21 10:44 ` Eric Dumazet
2021-12-21 15:25 ` Jens Axboe [this message]
2021-12-21 16:03 ` Eric Dumazet
2021-12-21 16:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3a30c8c-3f1a-47b5-57e7-1b456bbc8719@kernel.dk \
--to=axboe@kernel.dk \
--cc=changbin.du@intel.com \
--cc=christian.brauner@ubuntu.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+8836466a79f4175961b0@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®