From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05DEE1D514E for ; Mon, 6 Jan 2025 09:56:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736157369; cv=none; b=TRD75UhBiOvh13X7Aii5xMV7Vm/rrYj9WmMZDAX5e/07SNP+FQVULJuaaUoU9cpL2V5s/lNyr2KN5WCO9tQln8fzSefyifqRnkQnozCHFN3xquJUZcR4EzfoA77Nyul93aa0I9X2f+wUtUghpF7ua2vQPIdmsQuAPCF949WsQiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736157369; c=relaxed/simple; bh=g/OoJEckbiVwHqoVZ/DJIoLLvVB6DKWKjEkArqzX77U=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=SU4vYzSmpUh+AaCO8LwhxGekLdL4wN2Fp3jSaaN1IMeSSoIGD1wADOYOnJttLRXvE5gXpdAmbkFERAGGAxyqrbYTNyLwZinTcxlyhxclztMBc3Ufk2dK77UbzoYGDGUeiaYW6Df6uYjJ5O17fBl8FqxfdtcWEu1mTaxKmCe6nUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JYt+RUeL; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JYt+RUeL" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-38637614567so6399943f8f.3 for ; Mon, 06 Jan 2025 01:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736157366; x=1736762166; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XPxusyoqlnRrNJq7+ups8OMfqGNcbuHMUJVymBouBjo=; b=JYt+RUeLSYwLCOVuk296pJMr3wiBC5C+seAPSM68KkOYJ/yjsB2Ya9omlItZaTfmN+ U3dwDTr3lcWaX3eYyjth51gFBEnOqwBiY1YoSeh6xtDIazhk0ye5uFaRkN+eYIY5Gf9X unFBTFgRGlqUI17IZy8RhkMj76AgJv2xqORmtFiOF/WTbd2NVRkgr/M0qBtHdjVTb7Vj BaQzDuBSnQL5z0YvX8EOQ7oqmBy6inus9B9rFTcd2xo3fCSLZCRdYIa+hcqiVjkk7LpO NlCM1EwhfNkXqiT6K+AkblSFvcw6hp3D8YpmTSx5heUSSXopSzEYvDsuiaYaFlBfjorC lykg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736157366; x=1736762166; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XPxusyoqlnRrNJq7+ups8OMfqGNcbuHMUJVymBouBjo=; b=OFV7UM/Kchel0VVxx4G0u0osjKLMMQxH5Hu0+6O8fZHcIMNMU2s4suJ54+ELxWpjGE CuvcCK5zJZp/xiUXI+zEVUNZh2a8LqSa9+lbdRcl1N4CUvNT6DUx/b/LtiQc3vblPHUp ocA7p7w3vGDQU1ysuOw9PWqvXtHxXRLJdTJg2gw6cWKLyzbCnzKJ4qOnjBasbk7sGBZo LKEFB3L6VZrER/TzvhLyxU8cKSwLNmMRUZyv3JN83e6W12eR8LaVRrB1JfnXjSOIp4fZ LDRp6/gEJv0YR92u3eWbkXu+6H7K+TFA+k3pS/HCgQVyWq9icnCoVz88jdRTkD43Ezta BV/A== X-Forwarded-Encrypted: i=1; AJvYcCXt2bfKKLreYZwrhJVQ42hdBEcQYXAjZaYnm1mN1yhv7uwWZtJhbWaSQWnVsAjziKFk4u98SUKXvK0Urjk=@vger.kernel.org X-Gm-Message-State: AOJu0YwRVgH6kvUdOge1D5K+BvXVfXdWvDprktpb7VvIi0J0VOSlHqSO lSRB+UpPfvuOsuPL83+13HCmEBSNO0gKuYH2DqMvnALQ9n5MZRkS5EQCfqy8Iqc= X-Gm-Gg: ASbGncsdY8KznootGlYL2uuRZZKZqQFIKYerqYEzhlk4hCCLaeKa1HTt8xh2tsdpmnD TvHUW5QStImipeY6Xg0OmqfQn2DdoBV62Fgb+3a4RZYyWFXFDtlXPihb4cDaAnPnKB2ya6On2sT RV8IRdN5Ui2aUU+BZEhltfpWoeJZE4D4ehagPos54rpujtMICuW9ahVLSydH/SXXMPqOnjR3qMh /UecXqCWl53rouGJyOSwrl6YoTRLUbOO25gBzChTRaZsiitRYedLwcjeizEFA== X-Google-Smtp-Source: AGHT+IGhWRISLmROsfexY/7S1VN3olm0rXAnp4XlnaP5acP2aBFiZteVn7JIK9wCL3+4yp5Vobvaww== X-Received: by 2002:a5d:6484:0:b0:388:da10:ea7e with SMTP id ffacd0b85a97d-38a221faea2mr45331915f8f.24.1736157366234; Mon, 06 Jan 2025 01:56:06 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43661219a08sm568953115e9.25.2025.01.06.01.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 01:56:05 -0800 (PST) Date: Mon, 6 Jan 2025 12:56:02 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Peter Geis , Heiko Stuebner Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Peter Geis , Caesar Wang , Detlev Casanova , Finley Xiao , Jonathan Cameron , Kevin Hilman , Krzysztof Kozlowski , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 1/6] pmdomain: rockchip: fix rockchip_pd_power error handling Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241210013010.81257-2-pgwipeout@gmail.com> Hi Peter, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Peter-Geis/pmdomain-rockchip-fix-rockchip_pd_power-error-handling/20241210-093424 base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next patch link: https://lore.kernel.org/r/20241210013010.81257-2-pgwipeout%40gmail.com patch subject: [PATCH 1/6] pmdomain: rockchip: fix rockchip_pd_power error handling config: powerpc-randconfig-r072-20241223 (https://download.01.org/0day-ci/archive/20241224/202412240015.MfjYhpNz-lkp@intel.com/config) compiler: powerpc-linux-gcc (GCC) 14.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202412240015.MfjYhpNz-lkp@intel.com/ smatch warnings: drivers/pmdomain/rockchip/pm-domains.c:614 rockchip_pd_power() warn: inconsistent returns '&pmu->mutex'. vim +614 drivers/pmdomain/rockchip/pm-domains.c 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 572 static int rockchip_pd_power(struct rockchip_pm_domain *pd, bool power_on) 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 573 { d909072d0521a8 drivers/soc/rockchip/pm_domains.c Jeffy Chen 2018-02-28 574 struct rockchip_pmu *pmu = pd->pmu; d909072d0521a8 drivers/soc/rockchip/pm_domains.c Jeffy Chen 2018-02-28 575 int ret; 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 576 d909072d0521a8 drivers/soc/rockchip/pm_domains.c Jeffy Chen 2018-02-28 577 mutex_lock(&pmu->mutex); 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 578 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 579 if (rockchip_pmu_domain_is_on(pd) != power_on) { d909072d0521a8 drivers/soc/rockchip/pm_domains.c Jeffy Chen 2018-02-28 580 ret = clk_bulk_enable(pd->num_clks, pd->clks); d909072d0521a8 drivers/soc/rockchip/pm_domains.c Jeffy Chen 2018-02-28 581 if (ret < 0) { d909072d0521a8 drivers/soc/rockchip/pm_domains.c Jeffy Chen 2018-02-28 582 dev_err(pmu->dev, "failed to enable clocks\n"); d909072d0521a8 drivers/soc/rockchip/pm_domains.c Jeffy Chen 2018-02-28 583 mutex_unlock(&pmu->mutex); d909072d0521a8 drivers/soc/rockchip/pm_domains.c Jeffy Chen 2018-02-28 584 return ret; d909072d0521a8 drivers/soc/rockchip/pm_domains.c Jeffy Chen 2018-02-28 585 } 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 586 8b579881de295d drivers/pmdomain/rockchip/pm-domains.c Detlev Casanova 2024-08-29 587 rockchip_pmu_ungate_clk(pd, true); 8b579881de295d drivers/pmdomain/rockchip/pm-domains.c Detlev Casanova 2024-08-29 588 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 589 if (!power_on) { 074c6a422d86ff drivers/soc/rockchip/pm_domains.c Elaine Zhang 2016-04-14 590 rockchip_pmu_save_qos(pd); 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 591 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 592 /* if powering down, idle request to NIU first */ a15817772c0ae6 drivers/pmdomain/rockchip/pm-domains.c Peter Geis 2024-12-10 593 ret = rockchip_pmu_set_idle_request(pd, true); a15817772c0ae6 drivers/pmdomain/rockchip/pm-domains.c Peter Geis 2024-12-10 594 if (ret < 0) a15817772c0ae6 drivers/pmdomain/rockchip/pm-domains.c Peter Geis 2024-12-10 595 return ret; mutex_unlock(&pmu->mutex); 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 596 } 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 597 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 598 rockchip_do_pmu_set_power_domain(pd, power_on); 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 599 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 600 if (power_on) { 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 601 /* if powering up, leave idle mode */ a15817772c0ae6 drivers/pmdomain/rockchip/pm-domains.c Peter Geis 2024-12-10 602 ret = rockchip_pmu_set_idle_request(pd, false); a15817772c0ae6 drivers/pmdomain/rockchip/pm-domains.c Peter Geis 2024-12-10 603 if (ret < 0) a15817772c0ae6 drivers/pmdomain/rockchip/pm-domains.c Peter Geis 2024-12-10 604 return ret; mutex_unlock(&pmu->mutex); 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 605 074c6a422d86ff drivers/soc/rockchip/pm_domains.c Elaine Zhang 2016-04-14 606 rockchip_pmu_restore_qos(pd); 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 607 } 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 608 8b579881de295d drivers/pmdomain/rockchip/pm-domains.c Detlev Casanova 2024-08-29 609 rockchip_pmu_ungate_clk(pd, false); d909072d0521a8 drivers/soc/rockchip/pm_domains.c Jeffy Chen 2018-02-28 610 clk_bulk_disable(pd->num_clks, pd->clks); 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 611 } 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 612 d909072d0521a8 drivers/soc/rockchip/pm_domains.c Jeffy Chen 2018-02-28 613 mutex_unlock(&pmu->mutex); 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 @614 return 0; 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 615 } 7c696693a4f54d drivers/soc/rockchip/pm_domains.c Caesar Wang 2015-09-08 616 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki