From: Justin Chen <justin.chen@broadcom.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Yuran Pereira <yuran.pereira@hotmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
florian.fainelli@broadcom.com, linux-kernel@vger.kernel.org,
edumazet@google.com, bcm-kernel-feedback-list@broadcom.com,
kuba@kernel.org, pabeni@redhat.com,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] Prevent out-of-bounds read/write in bcmasp_netfilt_rd and bcmasp_netfilt_wr
Date: Fri, 3 Nov 2023 11:23:16 -0700 [thread overview]
Message-ID: <e3ac58b2-bb78-4364-94c0-f18c376ac132@broadcom.com> (raw)
In-Reply-To: <2023110301-purist-reputable-fab7@gregkh>
[-- Attachment #1: Type: text/plain, Size: 2055 bytes --]
On 11/3/23 5:57 AM, Greg KH wrote:
> On Fri, Nov 03, 2023 at 05:57:48PM +0530, Yuran Pereira wrote:
>> The functions `bcmasp_netfilt_rd` and `bcmasp_netfilt_wr` both call
>> `bcmasp_netfilt_get_reg_offset` which, when it fails, returns `-EINVAL`.
>> This could lead to an out-of-bounds read or write when `rx_filter_core_rl`
>> or `rx_filter_core_wl` is called.
>>
>> This patch adds a check in both functions to return immediately if
>> `bcmasp_netfilt_get_reg_offset` fails. This prevents potential out-of-bounds read
>> or writes, and ensures that no undefined or buggy behavior would originate from
>> the failure of `bcmasp_netfilt_get_reg_offset`.
>>
>> Addresses-Coverity-IDs: 1544536 ("Out-of-bounds access")
>> Signed-off-by: Yuran Pereira <yuran.pereira@hotmail.com>
>> ---
>> drivers/net/ethernet/broadcom/asp2/bcmasp.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
>> index 29b04a274d07..8b90b761bdec 100644
>> --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c
>> +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
>> @@ -227,6 +227,8 @@ static void bcmasp_netfilt_wr(struct bcmasp_priv *priv,
>>
>> reg_offset = bcmasp_netfilt_get_reg_offset(priv, nfilt, reg_type,
>> offset);
>> + if (reg_offset < 0)
>> + return;
>>
>> rx_filter_core_wl(priv, val, reg_offset);
>> }
>> @@ -244,6 +246,8 @@ static u32 bcmasp_netfilt_rd(struct bcmasp_priv *priv,
>>
>> reg_offset = bcmasp_netfilt_get_reg_offset(priv, nfilt, reg_type,
>> offset);
>> + if (reg_offset < 0)
>> + return 0;
>
> Shouldn't you return an error here?
>
> thanks
>
> greg k-h
As long as offset is less than MAX_WAKE_FILTER_SIZE we don't need to
worry about error checking. This is already checked before we call
netfilt_get_reg_offset() in both cases. Instead of returning -EINVAL in
neffilt_get_reg_offset() lets return 0. This will silence the coverity
check. In practice we will never hit this logic.
Thanks,
Justin
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]
next prev parent reply other threads:[~2023-11-03 18:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 12:27 Yuran Pereira
2023-11-03 12:57 ` Greg KH
2023-11-03 13:42 ` Yuran Pereira
2023-11-03 14:14 ` Yuran Pereira
2023-11-03 14:19 ` Yuran Pereira
2023-11-03 18:23 ` Justin Chen [this message]
2023-11-03 18:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ac58b2-bb78-4364-94c0-f18c376ac132@broadcom.com \
--to=justin.chen@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yuran.pereira@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®