From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24CA73E5ED8 for ; Wed, 13 May 2026 14:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778681931; cv=none; b=LV5bxwSl9BLBc8+HCS0cEYX2DrbKKTaNERBXuKdlOzqqdKwAc+EGsLHWV/jN6WGsLDTgJlkUXxMgWL/ModUeL4CinWNvMMF45VbdNWKS8CnZ8hg/mA/gXPCS8K3qZyLewEoDrS8g1mBfxPS9Sf9D9sAz+j5U2RW6pJ6LG4ODuLI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778681931; c=relaxed/simple; bh=zcY7FUBNhO74nxP+DA38C8U6lBo8ZKlML3Nf1QLj804=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sInvhUUdjfH42s2RgJ8QCaOYoYKg8rUy8CYlxU/JZAU33qjzo0qFn68sFYnK4sQZ9e1XDivsh72yY2DzsMmjml2NIprBAywntebdm0PQr2m5AtGUNpNid1ZHhimIX8TmYrR46fWDm15m2/ljAkoxD5/nJ56MM9XHjGPXyvRCir4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MGXuaUfy; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MGXuaUfy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778681926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xYlye75OCf2YtQTajLfzvkg89uVXgpLkqgB1sCbwhbY=; b=MGXuaUfyiBZOawY1aO9SOj1dv4WkJ03W4f1y/y3w+WolCgxlKxpxwR5UWHspVUsm+02Wo0 p+ZaF5s8+rxIao7emQzb1Fw3U87lACYeoxp09QAEiSICo6IzRyVPrT+CaA2r9Tsst9gQdF ZWMWdUywYfzzYAO63U/84SoQTZKKCQg= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-193-r898SbB2NceqcCxJ1z_IKA-1; Wed, 13 May 2026 10:18:44 -0400 X-MC-Unique: r898SbB2NceqcCxJ1z_IKA-1 X-Mimecast-MFC-AGG-ID: r898SbB2NceqcCxJ1z_IKA_1778681924 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5104b861649so205447271cf.1 for ; Wed, 13 May 2026 07:18:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778681924; x=1779286724; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xYlye75OCf2YtQTajLfzvkg89uVXgpLkqgB1sCbwhbY=; b=GJghY6dL6uDay3vgKjbaby5S+/KW+07rMrDCTblyzv/LULzY0PPK0wHTkNwmpSTTQE UoccdbpYyt16yRR6mcvJ/Bu5pu1XvKJBqL1kkWQOuST7vr8lqkMCT2ImuW64ogr258KX JUWhA7CeKD/SYmbU5gY9aFLNN6fG0EU3MmtpWZp82KoPlTAzQq1KVqjTIfIrIAjKn7V1 hRcjmYEtmvnwBvPEyGBH5xISfmKH5G4udd6Hqxcbv2ZoI+Nof33qRF9RFAima+aP9fO0 BvgUd5JWMKTJ3gRwFjj2FO7U4nesUSneptGDJltfp85mN3f//5OBilKy6sskB53Kfl8c YRFA== X-Forwarded-Encrypted: i=1; AFNElJ8iizy9eh8pkJGcCqOkERCprQD4uv9Odd9mG+lCNOgPUOv+dx6BDKCF66Fq2ZlB6OP1XuZ7+jmIJbMe7c4=@vger.kernel.org X-Gm-Message-State: AOJu0YyVaevleboLJg0wsdkUh9MRHb1CO5LyfQtgabBAMmMcLR9i7aWq h/598etGJR+xN0Xb9fj3quMEi2FF55MG2QaxZLPi5/FUj5abOh9VJbRoWmo26thSXfAPGoD9tJU hTqNy+44BwfPjBrIbChtaCAujfKDrk75YQ2q3MrGV3gIbPS8kZSQC+D+1f9nqhe8g+A== X-Gm-Gg: Acq92OHuUGd2mLMKGPVALroWICC5Cpjpi0d7WIkkI+z0uLIrLTkA9U/a1wPxD1zm3sL pqEG6UeZ8xK4V9Lv0BN3Q/POPaWPLD0jmBCWMPTYia/gBFvhojhFitPsMjFnyeI9HN8kNVSWi7y Lbi2NU06dioKdWcs1XaXa89OaXk/LZ+PDKj7JCJHcc9slYZvWD93vZMlPVmhqB0+XQdXOgQHmgO hlVEQAoNDEXnZpWGmDa6Ej3dditOWLtOC2buVJpAdHZKHmgUiPnvnu9STCNgL36q1jTyY7nssOU uXejttNvPkpUXx3p4C9ONzMN58DWr2BaurDxu+zXXBswl+Cs+C3McrXSQQd8LkDInQ7nzTyVoAc k3kzrXd/GmgJlK3nhMxxz2b5n X-Received: by 2002:a05:622a:5c85:b0:50b:3788:ab59 with SMTP id d75a77b69052e-5162f4b00dfmr48896681cf.22.1778681924104; Wed, 13 May 2026 07:18:44 -0700 (PDT) X-Received: by 2002:a05:622a:5c85:b0:50b:3788:ab59 with SMTP id d75a77b69052e-5162f4b00dfmr48895661cf.22.1778681923428; Wed, 13 May 2026 07:18:43 -0700 (PDT) Received: from [192.168.2.110] ([70.53.202.134]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5148e6336c0sm160633171cf.2.2026.05.13.07.18.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 07:18:43 -0700 (PDT) Message-ID: Date: Wed, 13 May 2026 10:18:31 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 04/55] selftests/mm: migration: properly cleanup fork()ed processes To: Mike Rapoport , Andrew Morton , David Hildenbrand Cc: Baolin Wang , Barry Song , Dev Jain , Donet Tom , Jason Gunthorpe , John Hubbard , "Liam R. Howlett" , Lance Yang , Li Wang , Leon Romanovsky , Lorenzo Stoakes , Mark Brown , Michal Hocko , Nico Pache , Peter Xu , Ryan Roberts , Sarthak Sharma , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Zi Yan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20260511162840.375890-1-rppt@kernel.org> <20260511162840.375890-5-rppt@kernel.org> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: <20260511162840.375890-5-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-05-11 12:27, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Several migration test use fork() to create worker processes. These > processes are later killed, but nothing collects their exit status and they > remain as zombies in the system. > > Add a helper function that kills the worker processes, waitpid()s for > them and verifies the exit status. > > Replace the loops that call kill() for each process with a call to that > helper. > > Reported-by: Luiz Capitulino > Tested-by: Luiz Capitulino > Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Luiz Capitulino > --- > tools/testing/selftests/mm/migration.c | 47 +++++++++++++++++++------- > 1 file changed, 35 insertions(+), 12 deletions(-) > > diff --git a/tools/testing/selftests/mm/migration.c b/tools/testing/selftests/mm/migration.c > index 16ffd3c55ee0..e504829df6b6 100644 > --- a/tools/testing/selftests/mm/migration.c > +++ b/tools/testing/selftests/mm/migration.c > @@ -67,6 +67,29 @@ FIXTURE_TEARDOWN(migration) > free(self->pids); > } > > +static bool kill_children(FIXTURE_DATA(migration) * self) > +{ > + bool err = false; > + pid_t pid; > + int i; > + > + for (i = 0; i < self->nthreads; i++) { > + int status = 0; > + > + pid = self->pids[i]; > + if (pid < 0) > + continue; > + if (kill(pid, SIGTERM)) > + err = true; > + if (pid != waitpid(pid, &status, 0)) > + err = true; > + if (!WIFSIGNALED(status) || WTERMSIG(status) != SIGTERM) > + err = true; > + } > + > + return !err; > +} > + > int migrate(uint64_t *ptr, int n1, int n2) > { > int ret, tmp; > @@ -151,7 +174,7 @@ TEST_F_TIMEOUT(migration, shared_anon, 2*RUNTIME) > { > pid_t pid; > uint64_t *ptr; > - int i; > + int i, err; > > ptr = mmap(NULL, TWOMEG, PROT_READ | PROT_WRITE, > MAP_SHARED | MAP_ANONYMOUS, -1, 0); > @@ -171,9 +194,9 @@ TEST_F_TIMEOUT(migration, shared_anon, 2*RUNTIME) > } > } > > - ASSERT_EQ(migrate(ptr, self->n1, self->n2), 0); > - for (i = 0; i < self->nthreads; i++) > - ASSERT_EQ(kill(self->pids[i], SIGTERM), 0); > + err = migrate(ptr, self->n1, self->n2); > + ASSERT_EQ(kill_children(self), true); > + ASSERT_EQ(err, 0); > } > > /* > @@ -217,7 +240,7 @@ TEST_F_TIMEOUT(migration, shared_anon_thp, 2*RUNTIME) > uint64_t pmdsize; > pid_t pid; > uint64_t *ptr; > - int i; > + int i, err; > > if (!thp_is_enabled()) > SKIP(return, "Transparent Hugepages not available"); > @@ -247,9 +270,9 @@ TEST_F_TIMEOUT(migration, shared_anon_thp, 2*RUNTIME) > } > } > > - ASSERT_EQ(migrate(ptr, self->n1, self->n2), 0); > - for (i = 0; i < self->nthreads; i++) > - ASSERT_EQ(kill(self->pids[i], SIGTERM), 0); > + err = migrate(ptr, self->n1, self->n2); > + ASSERT_EQ(kill_children(self), true); > + ASSERT_EQ(err, 0); > } > > /* > @@ -287,7 +310,7 @@ TEST_F_TIMEOUT(migration, shared_anon_htlb, 2*RUNTIME) > unsigned long hugepage_size; > pid_t pid; > uint64_t *ptr; > - int i; > + int i, err; > > hugepage_size = default_huge_page_size(); > if (!hugepage_size) > @@ -311,9 +334,9 @@ TEST_F_TIMEOUT(migration, shared_anon_htlb, 2*RUNTIME) > } > } > > - ASSERT_EQ(migrate(ptr, self->n1, self->n2), 0); > - for (i = 0; i < self->nthreads; i++) > - ASSERT_EQ(kill(self->pids[i], SIGTERM), 0); > + err = migrate(ptr, self->n1, self->n2); > + ASSERT_EQ(kill_children(self), true); > + ASSERT_EQ(err, 0); > } > > TEST_HARNESS_MAIN