From: Markus Elfring <Markus.Elfring@web.de>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
kernel-janitors@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: sched/topology: One function call less in build_group_from_child_sched_domain()
Date: Mon, 8 Jul 2019 17:44:13 +0200 [thread overview]
Message-ID: <e3ae5bd2-d963-2422-d4f0-131a5d2edbb4@web.de> (raw)
In-Reply-To: <20190708140751.GA10675@linux.vnet.ibm.com>
> Yes, it definitely makes code readable.
Some developers seem to get difficulties with this view.
> I was only commenting on the changelog/subject which says
> avoids a function call which I think it doesn't.
Do you prefer an other wording for calling functions only once
with a selected parameter value instead of calling them (unoptimised)
within two branches of an if statement?
Regards,
Markus
prev parent reply other threads:[~2019-07-08 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 14:05 [PATCH] " Markus Elfring
2019-07-06 17:22 ` Srikar Dronamraju
2019-07-08 9:38 ` Enrico Weigelt, metux IT consult
2019-07-08 14:27 ` Srikar Dronamraju
2019-07-08 10:23 ` Peter Zijlstra
2019-07-08 14:07 ` Srikar Dronamraju
2019-07-08 15:44 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ae5bd2-d963-2422-d4f0-131a5d2edbb4@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®