From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81F7741A93A for ; Thu, 23 Jul 2026 12:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784808702; cv=none; b=dFD8nbeGFvxML72M/lIgo30HxGS3O6XyhEb99qH1nV1bjLEuQRiUMq7fDIpy5206zK9HqK+XgiQcE2fPxx9BWmcC1hrkQ3KjRQOg9yqCMVRVQ+IVmfnBlSsIYpQUeiuzHwNuPpPn6iK60PVqKV97t7+mPVvsvhO5CzHyrh9i/kE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784808702; c=relaxed/simple; bh=eAQv8n4LKSI7IE8oTDl69Kvwj8o4JmZgxArnJbuS3IE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KT6xxEofAG0wma4wgAPk/nAsSgn69ZWfBJgmDmd+kvoxqh0v9GmVW46qlIsn0c2nhhRyxmzOqJCKVt93Iron8Ztrm++3qnQ5I/29I26tqFZOIF8Uy+lClMB7CQQIdqe2GaUs9TpO9RO0IwEzeHI2qK8q7thFkSmJL66BuedQow8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Nrer3eAH; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Nrer3eAH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1784808693; bh=eAQv8n4LKSI7IE8oTDl69Kvwj8o4JmZgxArnJbuS3IE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Nrer3eAHekVF0EkiS1q4CVQMuZPVDJXsFWQlFxXSQAJCcki9IcvnVUQ5GZec1L3zi TKvb/wwisc6cTlVeb6t2dGC6QdBtXYRcqOk+nHnIn1rH5VbHJ49s3A/uU7Ozm5GeB3 e8mRHOvOaqXacoMXQUmIw2Nno9Y3Gc7T8QS1SeAhxawFIyycOX9gscN8Ckl71ugFZ6 iBOVFk0dxDvAlQjXmFPqQO1Dk+tvnaEisThvJBu/GO2Ht+9hOFx/aFsb+hcCMy7oAj MQtGbdPBXz/qr6pg/0+/Hi94CGMYdmfOAnEa6D2hGoahDKtdREUAFenQOJeREt0X2Z 5Qk6PjtwScyJg== Received: from [100.64.0.241] (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id CBFF917E0114; Thu, 23 Jul 2026 14:11:32 +0200 (CEST) Message-ID: Date: Thu, 23 Jul 2026 15:11:32 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/8] phy: rockchip: samsung-hdptx: Drop TMDS rate setup workaround To: Andy Yan , Vinod Koul , Neil Armstrong , Heiko Stuebner , Algea Cao , Dmitry Baryshkov Cc: kernel@collabora.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Thomas_Niederpr=C3=BCm?= , Simon Wright References: <20260612-hdptx-clk-fixes-v4-0-ce5e1d456cda@collabora.com> <20260612-hdptx-clk-fixes-v4-5-ce5e1d456cda@collabora.com> <40179247-12ac-4768-abd9-37f34e2c8b2b@rock-chips.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <40179247-12ac-4768-abd9-37f34e2c8b2b@rock-chips.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Andy, On 7/23/26 2:51 PM, Andy Yan wrote: > Hello, > > On 6/12/26 07:45, Cristian Ciocaltea wrote: >> Since commit ba9c2fe18c17 ("drm/rockchip: dw_hdmi_qp: Switch to >> phy_configure()") the TMDS rate setup doesn't rely anymore on the >> unconventional usage of the bus width, instead it is managed exclusively >> through the HDMI PHY configuration API. >> >> Drop the now obsolete workaround to retrieve the TMDS character rate via >> phy_get_bus_width() during power_on(). >> >> While at it, get rid of the extra call to rk_hdptx_phy_consumer_put() by >> moving the statement at the end of the function. >> >> Tested-by: Thomas Niederprüm >> Tested-by: Simon Wright >> Signed-off-by: Cristian Ciocaltea > > Reviewed-by: Andy Yan Dmitry suggested moving the code cleanup around rk_hdptx_phy_consumer_put() into a separate commit, so I'll handle it in v5, which I'll send later today. Since this has no functional implications, I'll retain your R-b for the updated patch. Thanks for reviewing the series! Cristian