From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752861AbeADLOG (ORCPT + 1 other); Thu, 4 Jan 2018 06:14:06 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:60140 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752159AbeADLOF (ORCPT ); Thu, 4 Jan 2018 06:14:05 -0500 Subject: Re: [PATCH v4 3/7] ARM: davinci: fix duplicate clocks To: David Lechner , CC: Kevin Hilman , Adam Ford , References: <1514763588-31560-1-git-send-email-david@lechnology.com> <1514763588-31560-4-git-send-email-david@lechnology.com> From: Sekhar Nori Message-ID: Date: Thu, 4 Jan 2018 16:42:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1514763588-31560-4-git-send-email-david@lechnology.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Monday 01 January 2018 05:09 AM, David Lechner wrote: > There are a number of clocks that were duplicated because they are used by > more than one device. It is no longer necessary to do this since we are > explicitly calling clk_register_clkdev() for each clock. In da830.c, some > clocks were using the same LPSC, which would cause problems with reference > counting, so these are combinded into one clock each. In da850.c the > duplicate clocks had already been fixed by creating dummy child clocks, so > these clocks are removed. > > Signed-off-by: David Lechner If we do end up keeping 2/7, this should be done before that - to avoid retouching code that was just introduced. Thanks, Sekhar